Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/6] Add serial and i2c aliases for Khadas VIM boards
To:     xieqinick@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org
Cc:     nick@khadas.com, artem@khadas.com, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org
References: <20210605062313.418343-1-xieqinick@gmail.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <4e1e960c-16b3-59a5-61c2-6d6e2f8204ac@baylibre.com>
Date:   Mon, 7 Jun 2021 09:01:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210605062313.418343-1-xieqinick@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nick,

On 05/06/2021 08:23, xieqinick@gmail.com wrote:
> From: Nick Xie <nick@khadas.com>
> 
> This patch series update / add serial and i2c aliases to
> keep the same with 4.9 kernel for Khadas VIM boards
> (VIM1, VIM2, VIM3 and VIM3L).
> 
> Nick Xie (6):
>   arm64: dts: meson: vim3: add serial aliases
>   arm64: dts: meson: vim1: update serial aliases
>   arm64: dts: meson: vim2: update serial aliases
>   arm64: dts: meson: vim3: add i2c aliases
>   arm64: dts: meson: vim1: add i2c aliases
>   arm64: dts: meson: vim2: add i2c aliases
> 
>  .../boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts      | 8 +++++++-
>  arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts    | 7 ++++++-
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi       | 9 +++++++++
>  3 files changed, 22 insertions(+), 2 deletions(-)
> 

Thanks for these patches.

I'm not sure about the current policy about aliases, but when we started upstreaming the amlogic boards,
only the exposed interfaces could have an alias and in the board.dts file only. But since other vendors
added a bunch of aliases of all the possible i2c/spi/uart/mmc/ethernet interfaces in the SoC dtsi....

But the question of the 40pins header remains, should we add aliases for interfaces present on the 40pin header ?????

Personally, we should'nt since these pins has no defined functions, so any alias should be added by a DT overlay loaded from U-boot.

But it's my own opinion.

Rob ? what's the current policy on that ?

Neil