Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Jun 2021 09:15:53 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Barry Song <song.bao.hua@hisilicon.com>
Cc:     hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/kprobes: remove free_insn_page since it is same with
 the common weak function
Message-ID: <YL3VuU/GQl6HWGq7@infradead.org>
References: <20210601040856.22080-1-song.bao.hua@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601040856.22080-1-song.bao.hua@hisilicon.com>
Precedence: bulk

On Tue, Jun 01, 2021 at 04:08:56PM +1200, Barry Song wrote:
> free_insn_page() in x86 is same with the common weak function in
> kernel/kprobes.c. Plus, its comment "Recover page to RW mode before
> releasing it" seems insensible to be there since resetting mapping
> is done by common code in vfree() of module_memfree().
> So drop the strong function and its comment in x86 totally.
> 
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>

It also is the same for s390, so please remove that as well and remove
the __weak.