Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1622996045-25826-1-git-send-email-faiyazm@codeaurora.org>
 <CAHp75VdM0aziN4zHaf6=z6D0Nb=+GTbjV1pdTpRZ=yxGDZRkhw@mail.gmail.com> <dd0e3e4e-7eba-039f-7b2b-3fb3131ce2eb@codeaurora.org>
In-Reply-To: <dd0e3e4e-7eba-039f-7b2b-3fb3131ce2eb@codeaurora.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 7 Jun 2021 11:42:31 +0300
Message-ID: <CAHp75VfQz4WGF3FvpPGLeYHtjEfWFB7gMUpWN7DHjgi1fc1X0w@mail.gmail.com>
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs
To:     Faiyaz Mohammed <faiyazm@codeaurora.org>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <greg@kroah.com>, glittao@gmail.com,
        vinmenon@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 7, 2021 at 5:40 AM Faiyaz Mohammed <faiyazm@codeaurora.org> wro=
te:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@codeaurora.org>=
 wrote:

...

> >> +               if (l->sum_time !=3D l->min_time) {
> >> +                       seq_printf(seq, " age=3D%ld/%ld/%ld",
> >> +                               l->min_time,
> >
> >> +                               (long)div_u64(l->sum_time, l->count),
> >
> > Hmm... Why is the cast needed here?
> >
> To avoid below warning while preparing build for arm/32 bit,
> "format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long int=
=E2=80=99, but argument 4 has
> type =E2=80=98u64 {aka long long unsigned int}" .

Perhaps use %llu?

> >> +                               l->max_time);
> >> +               } else
> >> +                       seq_printf(seq, " age=3D%ld",
> >> +                               l->min_time);

--=20
With Best Regards,
Andy Shevchenko