Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d222e3a93d192722099994441283193d6ed26a79.camel@pengutronix.de>
Subject: Re: [PATCH -next] reset: mchp: sparx5: fix return value check in
 mchp_sparx5_map_io()
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Wei Yongjun <weiyongjun1@huawei.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        UNGLinuxDriver@microchip.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Date:   Mon, 07 Jun 2021 11:23:28 +0200
In-Reply-To: <20210519141638.3052456-1-weiyongjun1@huawei.com>
References: <20210519141638.3052456-1-weiyongjun1@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2021-05-19 at 14:16 +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_get_and_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
> 
> Fixes: 453ed4283beb ("reset: mchp: sparx5: add switch reset driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thank you, applied to reset/fixes.

regards
Philipp