Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Jun 2021 17:44:45 +0800
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: berlin: support module build
Message-ID: <20210607174445.3d532e6b@xhacker.debian>
In-Reply-To: <9f5bee632ed493b150c47f3127242c259a385192.camel@pengutronix.de>
References: <20210520171316.395de63e@xhacker.debian>
        <9f5bee632ed493b150c47f3127242c259a385192.camel@pengutronix.de>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from xhacker.debian (192.147.44.204) by SJ0PR03CA0283.namprd03.prod.outlook.com (2603:10b6:a03:39e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22 via Frontend Transport; Mon, 7 Jun 2021 09:44:54 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a58e1bed-5693-4aa7-a989-08d92998e7fe
X-MS-TrafficTypeDiagnostic: BN6PR03MB3379:
X-Microsoft-Antispam-PRVS: <BN6PR03MB3379ADDB12B34EFA3D9277C3ED389@BN6PR03MB3379.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5LKnCwu2T62BjuTcZEdSYYrxH9Zk5Ira/FWpHGOaM/ZQs7srHTuzD8XiJCKFuYPaTtNTP8/HaaddQ9l0TpB/1WwXTNuvAdfMsuCMs+xwDXdXKWRWxssFDIpzYTDvEelgYj1zuoSsVhWPJNwijW2wL7iloa43dG9cXRKdkYkqzvRA5UbqHGiEr9t1TJMy6WKUH/g+SIurHdBmPiu0EOgeKQ4sr7jcLJ2mnD3jFLroyd3SbU4uEXVxfQ3tzomIbGcECyyfAsPqoyJ7fvZyffXHifYgaLURSBQyu9DXL+FdREZP7qiuvNxhYbW5XkmZ/6S1+wtDw54fNAB8FMcbTdTum/bjsdOCgUMIELMx5nt6pflmCqxhyvtVCDBRVnIbK9IcjwdCV5PSqKtMuLjn/i4O0SGcep6yOr7QnxJZYPYxAzswX5j3IyvsAJzTWRsqktohoNosrzEW02wKkrMg1s5WGXQ87+wUeY1Al0LD3U5FTNGkNClhuRxbtCntdCQ4cZqFnJQTKE16BG79ds6vrBCDesWbe1QIQqyTQtaeCKWlt+gOUV3osqyJl/EWLkX2kSZStGHYuv/M/K7wV1pnjRWnDJfrSSRGfgF2z0rpJoSvmu3RHt4kjwA/5TTxQkJTOL9uUaX24soBpjaHcbhD7Sra4rmv4WVyfb8a+7h7a1ve2W0=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR03MB6058.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(39860400002)(396003)(366004)(7696005)(52116002)(8936002)(83380400001)(6916009)(2906002)(6506007)(86362001)(4326008)(956004)(55016002)(66476007)(1076003)(66556008)(9686003)(26005)(478600001)(186003)(5660300002)(38350700002)(16526019)(38100700002)(316002)(6666004)(8676002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?zeqHjZcfbwDvAqhdsCEVh4tZki0Q+hZ6m/2JKN/efuhMREpSNmKS9HE5iKg3?=
 =?us-ascii?Q?YDeCNfPSE+dePY1k24ZiKgscwFnIRBzbN09HO4VnbVIFcTmjKTcMwBII9dyN?=
 =?us-ascii?Q?S76STWeGBZJfPGXVhIhly0TY3NjfNPHmw/Jft0fwAsjThCxTOlwSlwxsQrdy?=
 =?us-ascii?Q?xpsEBCYlKyUcwAp7BiA7FWpiZH7mbKUUL2MgbeWvyXw9IyFSV2YihjnkuYV+?=
 =?us-ascii?Q?APLGKbiVOie34H+aQgaNVWz4fJq0bT+8TwAqx5uD6BY/tjCxDbFh2WK0WIIE?=
 =?us-ascii?Q?lai6YP5Sd35M6Rpizqd0jIhQWY4rf38azugkDLsWT07mATBlJ2rsjlHUdYTq?=
 =?us-ascii?Q?Ac82NrNksqa5zddKBUuyOiiXiB6EjODCy+z15yMqM55dgSFYRnbRynbwMHfD?=
 =?us-ascii?Q?FjdtVv63pdizEu7zJhq15H1GIDQBp+B0xR1PnSbU6G7Ze+zOZzVouFsEDkNg?=
 =?us-ascii?Q?QHEj8Nx1+fYCSuOAtr2SJ8q2LgCHz7KxA6PGvP7TwRMgnMPJjHKGgQz4q5wz?=
 =?us-ascii?Q?5CMePUq1KU9H++MGawa0P+N1MaZ3TnhtCOIQciPjZkiXfH+6hlhS0XgdeYqv?=
 =?us-ascii?Q?IkREUFhZ84/dCZNLUPoeZzxbeNBZWo7udTJ8lzYDGvAEXyVWPYefkR1dcLL0?=
 =?us-ascii?Q?ofaGZVYA1L1lJb+ouF3UfeRl/Hif5OPHJZIsf+bZS/V4nOyYWdKwFAA17umY?=
 =?us-ascii?Q?BAhIBlZWjq12rtSTwuGH+EAquDUUbt3iCTc07eEldycRzQD9psaYDj91lATA?=
 =?us-ascii?Q?vyUDpcc3Y4FyRrXWCmnHcgQKDNhBTiwsxu1v7YamdbesB1bMUeaeR7ez1Jlp?=
 =?us-ascii?Q?xJgrP9hKW9ayWRCp8/gZE8VKLrylsR32matT5CDAzgguB2fXKHdPGQcUZpNI?=
 =?us-ascii?Q?gKhLREWAaNORAS9qUXAPY4Ohsc2fO8z/y12Cq99snhz8fgX4kweTMPj26hB4?=
 =?us-ascii?Q?WCp0VEIVMwIT0RlKVM30lAMYqbXKKUh909X47uYSKXpUGbQnSbLGdzd7ljce?=
 =?us-ascii?Q?Ml5HNxyZZAvdrcqNhdS9oKWooeWarMFvbXyX40lxEmPV5uMdlZzaQpZfg5iG?=
 =?us-ascii?Q?VX+nya8wN57YK4YDYxmtl5HzYPyy38WfFheWoUQq1oMQHzsWHrXBVwYrqG9K?=
 =?us-ascii?Q?/R+7Ia8hJ8dUiGPnk/xWbCL3gka1JDp9sqvQlIOcC7MkOsp8pifQXL0obl/s?=
 =?us-ascii?Q?Vw4cgp3urvC1yg9K7326OS3HSkEDAnQ1bQYBwMoQ4nKj8tjKY16IZbH+t7wE?=
 =?us-ascii?Q?XDnHO2IVdKFkJSquP8wSYd0Vu43wKCcb33y7N0LvvyynOxhD4ePcZdOGZVSt?=
 =?us-ascii?Q?BvQaYB8cuPOCOAsTjq1Phl6J?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a58e1bed-5693-4aa7-a989-08d92998e7fe
X-MS-Exchange-CrossTenant-AuthSource: BN9PR03MB6058.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2021 09:44:55.5223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VLLH52PclYbM8AC4kz3vA/aCTYJxujNdfNHaCutF4nrdzRshXhJZzjdMXxPsYYml8uBmAzMJoUt0TENrwYbXsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3379
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 07 Jun 2021 11:23:57 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:


> 
> 
> On Thu, 2021-05-20 at 17:13 +0800, Jisheng Zhang wrote:
> > Make reset-berlin driver to be tristate module, support to build as
> > a module, this is useful for GKI.
> >
> > Partially revert commit ed4dba99cae8 ("reset: berlin: make it
> > explicitly non-modular")
> >
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > ---
> >  drivers/reset/Kconfig        |  4 ++--
> >  drivers/reset/reset-berlin.c | 10 ++++++++--
> >  2 files changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 3e7f55e44d84..1e7443a4dae1 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -43,8 +43,8 @@ config RESET_BCM6345
> >         This enables the reset controller driver for BCM6345 SoCs.
> >
> >  config RESET_BERLIN
> > -     bool "Berlin Reset Driver" if COMPILE_TEST
> > -     default ARCH_BERLIN
> > +     tristate "Berlin Reset Driver"
> > +     depends on ARCH_BERLIN || COMPILE_TEST  
> 
> Is there a reason not to keep "default ARCH_BERLIN"?
> 

Hi,

After this patch, the reset driver will be built as module in most cases
so I removed default ARCH_BERLIN

Thanks