Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <09cc7bc4b14b4995352bd4bd08d3aee556202c06.camel@pengutronix.de>
Subject: Re: [PATCH] reset: berlin: support module build
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc:     linux-kernel@vger.kernel.org
Date:   Mon, 07 Jun 2021 12:01:00 +0200
In-Reply-To: <20210607175642.1c0e8ba4@xhacker.debian>
References: <20210520171316.395de63e@xhacker.debian>
         <9f5bee632ed493b150c47f3127242c259a385192.camel@pengutronix.de>
         <20210607174445.3d532e6b@xhacker.debian>
         <562cabc4162d9f2c0fb3a307213ec1c5b4bb5535.camel@pengutronix.de>
         <20210607175642.1c0e8ba4@xhacker.debian>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2021-06-07 at 17:56 +0800, Jisheng Zhang wrote:
> On Mon, 07 Jun 2021 11:49:45 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
> 
> 
> > 
> > On Mon, 2021-06-07 at 17:44 +0800, Jisheng Zhang wrote:
> > > On Mon, 07 Jun 2021 11:23:57 +0200
> > > Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > > 
> > >  
> > > > On Thu, 2021-05-20 at 17:13 +0800, Jisheng Zhang wrote:  
> > > > > Make reset-berlin driver to be tristate module, support to build as
> > > > > a module, this is useful for GKI.
> > > > > 
> > > > > Partially revert commit ed4dba99cae8 ("reset: berlin: make it
> > > > > explicitly non-modular")
> > > > > 
> > > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > > > > ---
> > > > >  drivers/reset/Kconfig        |  4 ++--
> > > > >  drivers/reset/reset-berlin.c | 10 ++++++++--
> > > > >  2 files changed, 10 insertions(+), 4 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > > > > index 3e7f55e44d84..1e7443a4dae1 100644
> > > > > --- a/drivers/reset/Kconfig
> > > > > +++ b/drivers/reset/Kconfig
> > > > > @@ -43,8 +43,8 @@ config RESET_BCM6345
> > > > >         This enables the reset controller driver for BCM6345 SoCs.
> > > > > 
> > > > >  config RESET_BERLIN
> > > > > -     bool "Berlin Reset Driver" if COMPILE_TEST
> > > > > -     default ARCH_BERLIN
> > > > > +     tristate "Berlin Reset Driver"
> > > > > +     depends on ARCH_BERLIN || COMPILE_TEST  
> > > > 
> > > > Is there a reason not to keep "default ARCH_BERLIN"?
> > > >  
> > > 
> > > Hi,
> > > 
> > > After this patch, the reset driver will be built as module in most cases
> > > so I removed default ARCH_BERLIN  
> > 
> > I see, how about "default m if ARCH_BERLIN" then?
> 
> Good idea. I think "default m" is enough, because we have a "depends on
> ARCH_BERLIN || COMPILE_TEST" above

"default m" would also enable the module for COMPILE_TEST by default,
which may not be what most compile testers need.

regards
Philipp