Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH wq/for-next 2/2] workqueue: let device core create the
 WQ_UNBOUND attributes
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20210607094420.2054403-1-jwi@linux.ibm.com>
 <20210607094420.2054403-2-jwi@linux.ibm.com> <YL30jJsS+xWMjGVa@kroah.com>
From:   Julian Wiedmann <jwi@linux.ibm.com>
Message-ID: <7b9366c0-13d9-a5ef-1a29-dd3510a831c0@linux.ibm.com>
Date:   Mon, 7 Jun 2021 13:34:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <YL30jJsS+xWMjGVa@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07.06.21 13:27, Greg Kroah-Hartman wrote:
> On Mon, Jun 07, 2021 at 11:44:20AM +0200, Julian Wiedmann wrote:
>> Wrap the attributes for a WQ_UNBOUND workqueue in ATTRIBUTE_GROUPS(),
>> and wire them up in dev->groups so that the device core can manage them
>> for us.
>>
>> As device_add() will add such attributes _prior_ to raising the KOBJ_ADD
>> uevent, this also makes the initial uevent suppression unnecessary.
>>
>> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
>> ---
>>  kernel/workqueue.c | 51 ++++++++++++++++++++--------------------------
>>  1 file changed, 22 insertions(+), 29 deletions(-)
>>
>> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
>> index 817dc2d7438a..629859ac5262 100644
>> --- a/kernel/workqueue.c
>> +++ b/kernel/workqueue.c
>> @@ -5449,6 +5449,9 @@ static ssize_t wq_pool_ids_show(struct device *dev,
>>  	return written;
>>  }
>>  
>> +static struct device_attribute wq_sysfs_unbound_attr_pool_ids =
>> +	__ATTR(pool_ids, 0444, wq_pool_ids_show, NULL);
> 
> __ATTR_RO() please.
> 

I did consider using DEVICE_ATTR_*(), yes. But renaming all the _show and _store
functions added too much unrelated churn for my taste. So let's maybe do this
as a follow-on?

>> +
>>  static ssize_t wq_nice_show(struct device *dev, struct device_attribute *attr,
>>  			    char *buf)
>>  {
>> @@ -5502,6 +5505,9 @@ static ssize_t wq_nice_store(struct device *dev, struct device_attribute *attr,
>>  	return ret ?: count;
>>  }
>>  
>> +static struct device_attribute wq_sysfs_unbound_attr_nice =
>> +	__ATTR(nice, 0644, wq_nice_show, wq_nice_store);
> 
> __ATTR_RW()
> 
>> +
>>  static ssize_t wq_cpumask_show(struct device *dev,
>>  			       struct device_attribute *attr, char *buf)
>>  {
>> @@ -5539,6 +5545,9 @@ static ssize_t wq_cpumask_store(struct device *dev,
>>  	return ret ?: count;
>>  }
>>  
>> +static struct device_attribute wq_sysfs_unbound_attr_cpumask =
>> +	__ATTR(cpumask, 0644, wq_cpumask_show, wq_cpumask_store);
> 
> __ATTR_RW()
> 
> thanks,
> 
> greg k-h
>