Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Jun 2021 12:57:53 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Barry Song <song.bao.hua@hisilicon.com>
Cc:     akpm@linux-foundation.org, hpa@zytor.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, gor@linux.ibm.com,
        borntraeger@de.ibm.com, naveen.n.rao@linux.ibm.com,
        anil.s.keshavamurthy@intel.com, davem@davemloft.net,
        mhiramat@kernel.org, linux-s390@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] kprobes: remove duplicated strong free_insn_page in
 x86 and s390
Message-ID: <YL37sTAUIfDulsDE@osiris>
References: <20210607091854.31580-1-song.bao.hua@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210607091854.31580-1-song.bao.hua@hisilicon.com>
Precedence: bulk

On Mon, Jun 07, 2021 at 09:18:54PM +1200, Barry Song wrote:
> free_insn_page() in x86 and s390 are same with the common weak function
> in kernel/kprobes.c.
> Plus, the comment "Recover page to RW mode before releasing it" in x86
> seems insensible to be there since resetting mapping is done by common
> code in vfree() of module_memfree().
> So drop these two duplicated strong functions and related comment, then
> mark the common one in kernel/kprobes.c strong.
> 
> Cc: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
>  -v2:
>  remove free_insn_page in s390 as well and remove the __weak in common
>  code according to Christoph's comment;
> 
>  arch/s390/kernel/kprobes.c     | 5 -----
>  arch/x86/kernel/kprobes/core.c | 6 ------
>  kernel/kprobes.c               | 2 +-
>  3 files changed, 1 insertion(+), 12 deletions(-)

For the s390 part:
Acked-by: Heiko Carstens <hca@linux.ibm.com>