Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210604170500.46875-1-kyle.meyer@hpe.com> <20210607032550.qdnl2sxnny42rtwa@vireshk-i7>
 <s5h35tuf8qd.wl-tiwai@suse.de> <20210607072637.b5mwcalab7y2vikx@vireshk-i7>
In-Reply-To: <20210607072637.b5mwcalab7y2vikx@vireshk-i7>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 7 Jun 2021 13:09:00 +0200
Message-ID: <CAJZ5v0jgH64Kbi12+tYbq384z5qEOKB68VELwtq28oiF1DjxkA@mail.gmail.com>
Subject: Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Kyle Meyer <kyle.meyer@hpe.com>
Cc:     Takashi Iwai <tiwai@suse.de>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 7, 2021 at 9:26 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 07-06-21, 09:13, Takashi Iwai wrote:
> > The missing key information is that it's a fix for the recent change
> > for 5.14, i.e.
> > Fixes: c1d6d2fd2f64 ("cpufreq: acpi-cpufreq: Skip initialization if cpufreq driver is present")
> >
> > The change made the module left even if it exits before registering
> > the cpufreq driver object.
>
> The original patch looks buggy to me, I was never able to review it :(
>
> I have replied on the original thread instead.

Well, thanks, but that confused me a bit.

Given the above, I'm going to drop the original patch.

Kyle, please reconsider this approach.