Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3174713pxj; Mon, 7 Jun 2021 04:22:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLxmGcWOW7ybNq9Hic2KHhL7swPfFX2GU+vxCZdxWyDuCNFg9PtF69PjYb53gwcA5PB5FE X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr17402498ejc.400.1623064946271; Mon, 07 Jun 2021 04:22:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623064946; cv=none; d=google.com; s=arc-20160816; b=qaCD0qCYNvT72pGxzsXfsYKIFRspRfBC2rlnUf7JhtHnuTuUoEXiMqxhGE0mkXakCu ORDMhTaVwxJ/shXrbxXc2DMAege189xrwCwa2mrr9nugtBRej0o43dj8oB7/Nu6TwmnF KZGkqN+rhwCVzzkDbW+fxBWj3ER6pD2d1Nr/Ho2EDxZk0ePU059XOKfRqjnDkhkGnlHh A9wUHSFfGsKiXfy6DwYRWx02plDKqhAu7+bjN0AgqChhjQTtvvw8K2+MjzQ1DiuXxMe8 hpFT4ASnTrAgdj50hl8u/tYUGOg46T/bb40tGEi510MKi0pynAHPvmY4MT0fo7XIOPoj kRbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=xxMqKO36SVZHd9Y9LSb8fPNfXAhR3AgWEpzV3qrtWiU=; b=Qfy85Rm3Sa2XLJOMO0lvLaLvzKXFaGHw95tX1ei/2t4ikJR4wU+2eHqm+xpeiAySrF OQzeEmuW9Su7ZUjk3TKnY/yfhXCH2u4UG9hyrjx4cBeIjtHoPxmGkB121YQpzX63Sbv4 ChJQb0uL3OKJmdZbQ2j1YIOb8nEKtHPIznjqL62GHhoK9tUSdmLAm+fUgsvOTnP83rPr 0w9Px+YiIrEcAHBiovcAQ1k5+wTy5vhexhW5N2bYcfP+rWkqpKPDdEFy3iGLyeaOkuVG tBd9WYIN1tDWizPuFED8mouLLDK6879X3RAyF9u3ZvrMz9jpIh6nH04zWpSSveYxJSd6 U/Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si12219983edq.76.2021.06.07.04.22.03; Mon, 07 Jun 2021 04:22:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbhFGLVN (ORCPT + 99 others); Mon, 7 Jun 2021 07:21:13 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:44728 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230374AbhFGLVK (ORCPT ); Mon, 7 Jun 2021 07:21:10 -0400 Received: from localhost (unknown [192.168.167.16]) by lucky1.263xmail.com (Postfix) with ESMTP id 1943FACE0F; Mon, 7 Jun 2021 19:19:17 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P32529T140357214529280S1623064756471506_; Mon, 07 Jun 2021 19:19:18 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <4e5a287637b8e7f452479ddb5d15e06c> X-RL-SENDER: jon.lin@rock-chips.com X-SENDER: jon.lin@rock-chips.com X-LOGIN-NAME: jon.lin@rock-chips.com X-FST-TO: broonie@kernel.org X-RCPT-COUNT: 9 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jon Lin To: broonie@kernel.org Cc: jon.lin@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 6/6] spi: rockchip: Support SPI_CS_HIGH Date: Mon, 7 Jun 2021 19:19:14 +0800 Message-Id: <20210607111914.31376-2-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210607111914.31376-1-jon.lin@rock-chips.com> References: <20210607111837.31074-1-jon.lin@rock-chips.com> <20210607111914.31376-1-jon.lin@rock-chips.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1.Add standard spi-cs-high support 2.Refer to spi-controller.yaml for details Signed-off-by: Jon Lin --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None drivers/spi/spi-rockchip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 48b666d42d8a..d64cca34eef7 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -108,6 +108,8 @@ #define CR0_OPM_MASTER 0x0 #define CR0_OPM_SLAVE 0x1 +#define CR0_SOI_OFFSET 23 + #define CR0_MTM_OFFSET 0x21 /* Bit fields in SER, 2bit */ @@ -238,7 +240,7 @@ static void rockchip_spi_set_cs(struct spi_device *spi, bool enable) { struct spi_controller *ctlr = spi->controller; struct rockchip_spi *rs = spi_controller_get_devdata(ctlr); - bool cs_asserted = !enable; + bool cs_asserted = spi->mode & SPI_CS_HIGH ? enable : !enable; /* Return immediately for no-op */ if (cs_asserted == rs->cs_asserted[spi->chip_select]) @@ -509,6 +511,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs, cr0 |= (spi->mode & 0x3U) << CR0_SCPH_OFFSET; if (spi->mode & SPI_LSB_FIRST) cr0 |= CR0_FBM_LSB << CR0_FBM_OFFSET; + if (spi->mode & SPI_CS_HIGH) + cr0 |= BIT(spi->chip_select) << CR0_SOI_OFFSET; if (xfer->rx_buf && xfer->tx_buf) cr0 |= CR0_XFM_TR << CR0_XFM_OFFSET; @@ -787,7 +791,7 @@ static int rockchip_spi_probe(struct platform_device *pdev) ctlr->auto_runtime_pm = true; ctlr->bus_num = pdev->id; - ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LOOP | SPI_LSB_FIRST; + ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LOOP | SPI_LSB_FIRST | SPI_CS_HIGH; if (slave_mode) { ctlr->mode_bits |= SPI_NO_CS; ctlr->slave_abort = rockchip_spi_slave_abort; -- 2.17.1