Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Tim Harvey <tharvey@gateworks.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] TDA1997x: enable EDID support
References: <m3sg1uq6xu.fsf@t19.piap.pl>
        <dbb99d7b-18eb-317c-911a-b982486848fa@xs4all.nl>
Sender: khalasa@piap.pl
Date:   Mon, 07 Jun 2021 13:56:25 +0200
In-Reply-To: <dbb99d7b-18eb-317c-911a-b982486848fa@xs4all.nl> (Hans Verkuil's
        message of "Mon, 7 Jun 2021 13:11:54 +0200")
Message-ID: <m3eeddhora.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Hans,

Hans Verkuil <hverkuil@xs4all.nl> writes:

>> Without this patch, the TDA19971 chip's EDID is inactive.
>
> Was this wrong from the very beginning? How can this ever have been tested
> without an EDID?

It seems so. I suspect it might have worked in tests because this
register isn't cleared on reboot. I.e., setting it once after power up
makes it work to the next power up.
Or, maybe, the HDMI signal source didn't need EDID.

I'm looking at the previous version of this driver from Gateworks and it
contains:

     /* Configure EDID
      *
      * EDID_ENABLE bits:
      *  7 - nack_off
      *  6 - edid_only
      *  1 - edid_b_en
      *  0 - edid_a_en
      */
     reg =3D io_read(REG_EDID_ENABLE);
     if (!tda1997x->internal_edid)
         reg &=3D ~0x83; /* EDID Nack ON */
     else
         reg |=3D 0x83;  /* EDID Nack OFF */
     io_write(REG_EDID_ENABLE, reg);

Not sure what the "non-internal" EDID could be - a separate I2C EEPROM
chip? I'm using this on Gateworks' GW54xx boards and I can't see any
such EEPROM in the vicinity of the TDA19971, but I don't know how it is
wired - perhaps Tim has some idea?
--=20
Krzysztof Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa