Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965242AbWKDTpz (ORCPT ); Sat, 4 Nov 2006 14:45:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965274AbWKDTpz (ORCPT ); Sat, 4 Nov 2006 14:45:55 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:5597 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S965242AbWKDTpy (ORCPT ); Sat, 4 Nov 2006 14:45:54 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: "Yinghai Lu" Cc: "Bryan O'Sullivan" , olson@pathscale.com, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 2/2] htirq: Allow buggy drivers of buggy hardware to write the registers. References: <454A7B0F.7060701@pathscale.com> <454B7B70.9060104@pathscale.com> <454B880A.1010802@pathscale.com> <454B8E19.90300@pathscale.com> <200611032146.kA3LkUe9031799@ebiederm.dsl.xmission.com> <86802c440611041137t74d84e7at3850fc8a10a314cb@mail.gmail.com> Date: Sat, 04 Nov 2006 12:45:22 -0700 In-Reply-To: <86802c440611041137t74d84e7at3850fc8a10a314cb@mail.gmail.com> (Yinghai Lu's message of "Sat, 4 Nov 2006 11:37:22 -0800") Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 542 Lines: 15 "Yinghai Lu" writes: > why not create one standard update function. and use that us default > for cfg->update It is faster and clearer what the normal case is not to have an update function. In practice I only ever expect one card to actually use the update function. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/