Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3217191pxj; Mon, 7 Jun 2021 05:27:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzwcb1yS1O+ZGssR8qJkG3ci2VPLvZ+QUo+aFDSvmqD/fDLOKAz2JbvOPFKjzmy5wVqoW1 X-Received: by 2002:aa7:d482:: with SMTP id b2mr19923679edr.45.1623068862896; Mon, 07 Jun 2021 05:27:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623068862; cv=none; d=google.com; s=arc-20160816; b=lWM1xiN5TzyFXf4Iy1aXN1haHCCQlMV8Eim5fJldPrASWRJZyZXUmmoNyUF2+e+gtN 6/KpA5YLKXOxNoHZKdYiJkBHDtW2GtCaxDdF+pPb+rG9MNm4EkAASoQ4iXCfMFf9KJBO lXAJYA4P0SaiTezE3yFPeawIZazDVpmH7p0OmNyKuBSGDM81oV6CJQ/cJKTCQ2GKH1Wi LgV47hl8gSCuUW0O4Db37rDa5xPVhscy37GiWWajLzw7/InOmkTIQcBFVApACWQD1NR5 4m0viQklkl8JkiERHlIg2UARYMY4uG/tLl8hXBDRUgAl77FdLVvvFj5KNjytUrV4vfoY M89g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=btYGGC1BOvfEC5zReMj8DfsuFMandCewlWGLx2WLnLk=; b=nsVbRW1cYZMBH98sBdAUnCmEjX3fow9FqGsLv0IDUsiFjOFICJTvLPFLagHcj9n47L sGc7fpHL2IprTzvJJ3rkoEPLU7fZ99HG96UC491Dev4NeCyc4HOelaW8z3ShvXTcBdC7 44d0gNO4zFkrBqQfXMm1RX9bcglmA8ODDKfuc5ecy+dwqO2fCk7N9wTcn2h+Tix/4moK /GWJcWzB/DUf6WGNHUWyg+vruI2zjjx5y5RVVuPsB43eANaJvrBQWZx37R0IPVfYsEjP 8D4MS2tu2zMPwuytwigcMO9huQZt1jKPwoRXXxWpmC1YEokTs27Oxp9yr3SndjLzUGKb KDnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a26si12209614edt.163.2021.06.07.05.27.20; Mon, 07 Jun 2021 05:27:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbhFGM1v (ORCPT + 99 others); Mon, 7 Jun 2021 08:27:51 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7128 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhFGM1t (ORCPT ); Mon, 7 Jun 2021 08:27:49 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FzCFS1dNkzYrCH; Mon, 7 Jun 2021 20:23:08 +0800 (CST) Received: from dggemi762-chm.china.huawei.com (10.1.198.148) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 20:25:56 +0800 Received: from linux-lmwb.huawei.com (10.175.103.112) by dggemi762-chm.china.huawei.com (10.1.198.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 7 Jun 2021 20:25:56 +0800 From: Zou Wei To: , CC: , , Zou Wei Subject: [PATCH -next] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq() Date: Mon, 7 Jun 2021 20:44:29 +0800 Message-ID: <1623069869-39309-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi762-chm.china.huawei.com (10.1.198.148) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing unlock before return from function mcp23s08_irq() in the error handling case. Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/pinctrl/pinctrl-mcp23s08.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 799d596..e12aa09 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -353,6 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data) if (intf == 0) { /* There is no interrupt pending */ + goto unlock; return IRQ_HANDLED; } -- 2.6.2