Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3220240pxj; Mon, 7 Jun 2021 05:32:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxadqxkZmIglLQdbAfvFvdjvYTrULOBM964hBvraGGbqdyiFQN7x6Nj692kffkzRO6lQaCY X-Received: by 2002:a17:906:c1d0:: with SMTP id bw16mr17810128ejb.146.1623069129717; Mon, 07 Jun 2021 05:32:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623069129; cv=none; d=google.com; s=arc-20160816; b=pnHv+ZJXPwyWw40AUBG8S5uN29c0czgSI69uJiCxhTKqpyt6t+Z5g/vl1BlTq8AZQF AQQI/sypzS3Dw9zN/qavTe34288n8u/hr6bpfklxwWnL0Az8ImqVbiVV4IglvJuOzFAH 9kqQbYCc7edgkmKd0qQ/SH6dieYqw0ce8ZZZGLmqs3ENS0uXfELCaNGoiojX/jkZL/jd +hCShn5QuDWlsFsnV5HVdx9Wc7Cdu4BKbwpekGqvNceYBaCyk5/S9Af8Oaz18xNrh8+q XZ0d0t4CHn1CzcCIl45rviowgH/TF7VrQFQ7UvygPuVx0d2kffRRK6nmbSpCJcO0qxVX TmyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=AbHgpVgSqpTCUBKES1pwwYM4xNz2+2ItrqAJoOEFbkU=; b=hLjNstrorusnUDE8AF8NnULfrouN4HkW9pItKsAHj7+NeyjFlFw3QHLX8Y3rQ3htGU 1nfkH33F8VOHIEqBqhqLGi10zX5pIqMZuKvW5TS0IBYxadSnJLqYiUL4AZu0u7I0U/15 0bvF9Wik0LAM4yB7JYapFiwRndQxkG/EyPoArAzKJbh/uYcPl/bKusq49ousL1t5vXss koihv+QBegth8QkAy0knaIwlhwrpca3WWSl0F1aV2yl5B/EzjwBzMVOnGTuza12Orkx9 UnXSIQSit1yWwWhoGMRWVjjalHdv7vTIdQmJkXvrJIu0eyI+adlg6+RBtl74NIUNO0KG Zppg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si2732100ejj.750.2021.06.07.05.31.46; Mon, 07 Jun 2021 05:32:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbhFGM3l (ORCPT + 99 others); Mon, 7 Jun 2021 08:29:41 -0400 Received: from mail.loongson.cn ([114.242.206.163]:53980 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230241AbhFGM3k (ORCPT ); Mon, 7 Jun 2021 08:29:40 -0400 Received: from linux.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxv0KaEL5gTV0MAA--.13959S2; Mon, 07 Jun 2021 20:27:07 +0800 (CST) From: Tiezhu Yang To: Alex Deucher , christian.koenig@amd.com, David Airlie , Daniel Vetter Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Xuefeng Li , Jianmin Lv Subject: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown() Date: Mon, 7 Jun 2021 20:27:00 +0800 Message-Id: <1623068820-2479-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9Dxv0KaEL5gTV0MAA--.13959S2 X-Coremail-Antispam: 1UD129KBjvJXoWruF4ftr4ruFyDKF4UKF15urg_yoW8JF1Upr W3GwsF9rn3tF4Fkay7ArW7JF13t3Z7GayxXrWvkw1DWws8A3s8Jr9aqFyUJry8urySgF12 qF1kG34ruF4xJr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkq14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW5JwCF 04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr 1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjsjjDUUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org radeon_suspend_kms() puts the hw in the suspend state (all asics), it should always call radeon_suspend_kms() in radeon_pci_shutdown(), this is a normal cleanup process to avoid more operations on radeon, just remove #ifdef CONFIG_PPC64 and the related comments. Co-developed-by: Jianmin Lv Signed-off-by: Jianmin Lv Signed-off-by: Tiezhu Yang --- drivers/gpu/drm/radeon/radeon_drv.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index efeb115..0b1f43d 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -386,16 +386,7 @@ radeon_pci_shutdown(struct pci_dev *pdev) if (radeon_device_is_virtual()) radeon_pci_remove(pdev); -#ifdef CONFIG_PPC64 - /* - * Some adapters need to be suspended before a - * shutdown occurs in order to prevent an error - * during kexec. - * Make this power specific becauase it breaks - * some non-power boards. - */ radeon_suspend_kms(pci_get_drvdata(pdev), true, true, false); -#endif } static int radeon_pmops_suspend(struct device *dev) -- 2.1.0