Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Jun 2021 21:32:08 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Barry Song <song.bao.hua@hisilicon.com>
Cc:     <akpm@linux-foundation.org>, <hpa@zytor.com>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>, <hca@linux.ibm.com>,
        <gor@linux.ibm.com>, <borntraeger@de.ibm.com>,
        <naveen.n.rao@linux.ibm.com>, <anil.s.keshavamurthy@intel.com>,
        <davem@davemloft.net>, <linux-s390@vger.kernel.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] kprobes: remove duplicated strong free_insn_page in
 x86 and s390
Message-Id: <20210607213208.b6d4bbda578a1f3aea93a9cb@kernel.org>
In-Reply-To: <20210607091854.31580-1-song.bao.hua@hisilicon.com>
References: <20210607091854.31580-1-song.bao.hua@hisilicon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 7 Jun 2021 21:18:54 +1200
Barry Song <song.bao.hua@hisilicon.com> wrote:

> free_insn_page() in x86 and s390 are same with the common weak function
> in kernel/kprobes.c.
> Plus, the comment "Recover page to RW mode before releasing it" in x86
> seems insensible to be there since resetting mapping is done by common
> code in vfree() of module_memfree().
> So drop these two duplicated strong functions and related comment, then
> mark the common one in kernel/kprobes.c strong.

Hm, OK. Actually riscv and arm64 uses __vmalloc() but anyway
since module_memfree() calls vfree(). So it has no problem.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

> 
> Cc: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
>  -v2:
>  remove free_insn_page in s390 as well and remove the __weak in common
>  code according to Christoph's comment;
> 
>  arch/s390/kernel/kprobes.c     | 5 -----
>  arch/x86/kernel/kprobes/core.c | 6 ------
>  kernel/kprobes.c               | 2 +-
>  3 files changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/arch/s390/kernel/kprobes.c b/arch/s390/kernel/kprobes.c
> index aae24dc75df6..60cfbd24229b 100644
> --- a/arch/s390/kernel/kprobes.c
> +++ b/arch/s390/kernel/kprobes.c
> @@ -44,11 +44,6 @@ void *alloc_insn_page(void)
>  	return page;
>  }
>  
> -void free_insn_page(void *page)
> -{
> -	module_memfree(page);
> -}
> -
>  static void *alloc_s390_insn_page(void)
>  {
>  	if (xchg(&insn_page_in_use, 1) == 1)
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index d3d65545cb8b..3bce67d3a03c 100644
> --- a/arch/x86/kernel/kprobes/core.c
> +++ b/arch/x86/kernel/kprobes/core.c
> @@ -422,12 +422,6 @@ void *alloc_insn_page(void)
>  	return page;
>  }
>  
> -/* Recover page to RW mode before releasing it */
> -void free_insn_page(void *page)
> -{
> -	module_memfree(page);
> -}
> -
>  /* Kprobe x86 instruction emulation - only regs->ip or IF flag modifiers */
>  
>  static void kprobe_emulate_ifmodifiers(struct kprobe *p, struct pt_regs *regs)
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 745f08fdd7a6..ddb643f3879f 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -106,7 +106,7 @@ void __weak *alloc_insn_page(void)
>  	return module_alloc(PAGE_SIZE);
>  }
>  
> -void __weak free_insn_page(void *page)
> +void free_insn_page(void *page)
>  {
>  	module_memfree(page);
>  }
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>