Message-ID: <454CF388.509@vmware.com>
Date: Sat, 04 Nov 2006 12:09:44 -0800
From: Zachary Amsden <zach@vmware.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20060909)
MIME-Version: 1.0
To: Linus Torvalds <torvalds@osdl.org>
Cc: Chuck Ebbert <76306.1226@compuserve.com>, Andi Kleen <ak@suse.de>,
       Andrew Morton <akpm@osdl.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] i386: remove IOPL check on task switch
References: <200611031900_MC3-1-D041-6F32@compuserve.com> <454CE7D9.3070308@vmware.com> <454CEC5C.2050507@vmware.com> <Pine.LNX.4.64.0611041152060.25218@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0611041152060.25218@g5.osdl.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 27

Linus Torvalds wrote:
> On Sat, 4 Nov 2006, Zachary Amsden wrote:
>   
>> Ok, checking shows Linus put it back to stop NT leakage.  This is correct, but
>> unlikely.  Would be nice to avoid it unless absolutely necessary.  Perhaps xor
>> eflags old and new and only set_system_eflags() if non-ALU bits have changed.
>>     
>
> Not just NT. AC also leaked, and caused crashes in other programs (Wine) 
> that didn't expect AC to be set and did unaligned accesses.

Yes, AC, NT, IOPL, ID are bad to leak.  DF / TF / RF are impossible to 
leak by privilege contract.  SF, ZF, PF, OF, CF can be clobbered.

VM / VIF / VIP are dealt with in separate switch paths (although I have 
witnessed a VIF leak once from a userspace process that managed to get 
VIF set).  These can't even be set with popf, and require iret to fix.

But 99% of the time, only SF / ZF / PF / OF / CF will be different, so 
you can avoid the popf.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/