Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Parav Pandit <parav@nvidia.com>
To:     Leon Romanovsky <leon@kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>
CC:     Greg KH <gregkh@linuxfoundation.org>,
        Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Adit Ranadive <aditr@vmware.com>,
        Ariel Elior <aelior@marvell.com>,
        Christian Benvenuti <benve@cisco.com>,
        "clang-built-linux@googlegroups.com" 
        <clang-built-linux@googlegroups.com>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Devesh Sharma <devesh.sharma@broadcom.com>,
        Gal Pressman <galpress@amazon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Michal Kalderon <mkalderon@marvell.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Potnuri Bharat Teja <bharat@chelsio.com>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        VMware PV-Drivers <pv-drivers@vmware.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: RE: [PATCH rdma-next v1 14/15] RDMA/core: Allow port_groups to be
 used with namespaces
Thread-Topic: [PATCH rdma-next v1 14/15] RDMA/core: Allow port_groups to be
 used with namespaces
Thread-Index: AQHXW3XTgmUrShoLP0aSfA0ttnjNH6sIiqTA
Date:   Mon, 7 Jun 2021 13:29:58 +0000
Message-ID: <PH0PR12MB5481C3DE73C097E938B4E5D1DC389@PH0PR12MB5481.namprd12.prod.outlook.com>
References: <cover.1623053078.git.leonro@nvidia.com>
 <a1a8a96629405ff3b2990f5f8dbd7b57a818571e.1623053078.git.leonro@nvidia.com>
In-Reply-To: <a1a8a96629405ff3b2990f5f8dbd7b57a818571e.1623053078.git.leonro@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f273cb05-4e94-4352-e562-08d929b85868
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2021 13:29:58.1037
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: njFbctC6g1YJFqVoKAwPlCFrJICxTnRfCAHt2wJcT2zJgEGWv34oCYd1b09H694iBb0BY5q4BFthDFDsNJeF6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5450
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: Leon Romanovsky <leon@kernel.org>
> Sent: Monday, June 7, 2021 1:48 PM
>=20
> From: Jason Gunthorpe <jgg@nvidia.com>
>=20
> Now that the port_groups data is being destroyed and managed by the core
> code this restriction is no longer needed. All the ib_port_attrs are comp=
atible
> with the core's sysfs lifecycle.
>=20
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/core/device.c | 10 ++++------
> drivers/infiniband/core/sysfs.c  | 17 ++++++-----------
>  2 files changed, 10 insertions(+), 17 deletions(-)
>=20
> diff --git a/drivers/infiniband/core/device.c
> b/drivers/infiniband/core/device.c
> index 2cbd77933ea5..92f224a97481 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -1698,13 +1698,11 @@ int ib_device_set_netns_put(struct sk_buff
> *skb,
>  	}
>=20
>  	/*
> -	 * Currently supported only for those providers which support
> -	 * disassociation and don't do port specific sysfs init. Once a
> -	 * port_cleanup infrastructure is implemented, this limitation will be
> -	 * removed.
> +	 * All the ib_clients, including uverbs, are reset when the namespace
> is
> +	 * changed and this cannot be blocked waiting for userspace to do
> +	 * something, so disassociation is mandatory.
>  	 */
> -	if (!dev->ops.disassociate_ucontext || dev->ops.port_groups ||
> -	    ib_devices_shared_netns) {
> +	if (!dev->ops.disassociate_ucontext || ib_devices_shared_netns) {
>  		ret =3D -EOPNOTSUPP;
>  		goto ns_err;
>  	}
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sy=
sfs.c
> index 09a2e1066df0..f42034fcf3d9 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -1236,11 +1236,9 @@ static struct ib_port *setup_port(struct
> ib_core_device *coredev, int port_num,
>  	ret =3D sysfs_create_groups(&p->kobj, p->groups_list);
>  	if (ret)
>  		goto err_del;
> -	if (is_full_dev) {
> -		ret =3D sysfs_create_groups(&p->kobj, device-
> >ops.port_groups);
> -		if (ret)
> -			goto err_groups;
> -	}
> +	ret =3D sysfs_create_groups(&p->kobj, device->ops.port_groups);
> +	if (ret)
> +		goto err_groups;
>=20
This will expose counters in all net namespaces in shared mode (default cas=
e).
Application running in one net namespace will be able to monitor counters o=
f other net namespace.
This should be avoided.