Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: faiyazm=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0FF56C433D3
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to
 debugfs
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <greg@kroah.com>, glittao@gmail.com,
        vinmenon@codeaurora.org
References: <1622996045-25826-1-git-send-email-faiyazm@codeaurora.org>
 <CAHp75VdM0aziN4zHaf6=z6D0Nb=+GTbjV1pdTpRZ=yxGDZRkhw@mail.gmail.com>
From:   Faiyaz Mohammed <faiyazm@codeaurora.org>
Message-ID: <d5c16162-91af-40ba-66dc-02ac5a6a48ef@codeaurora.org>
Date:   Mon, 7 Jun 2021 19:24:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VdM0aziN4zHaf6=z6D0Nb=+GTbjV1pdTpRZ=yxGDZRkhw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
>>
>> alloc_calls and free_calls implementation in sysfs have two issues,
>> one is PAGE_SIZE limitiation of sysfs and other is it does not adhere
> 
> limitation
> 
>> to "one value per file" rule.
>>
>> To overcome this issues, move the alloc_calls and free_calls implemeation
> 
> implementation
> 
>> to debugfs.
>>
>> Debugfs cache will be created if SLAB_STORE_USER flag is set.
>>
>> Rename the alloc_calls/free_calls to alloc_traces/free_traces,
>> to be inline with what it does.
> 
> ...
> 
>> +#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_SLUB_DEBUG)
>> +void debugfs_slab_release(struct kmem_cache *);
>> +#else
> 
>> +static inline void debugfs_slab_release(struct kmem_cache *s)
>> +{
>> +}
> 
> It can be one line.
> 
>> +#endif
> 
> ...
> 
> 
>> +               if (l->sum_time != l->min_time) {
>> +                       seq_printf(seq, " age=%ld/%ld/%ld",
>> +                               l->min_time,
> 
>> +                               (long)div_u64(l->sum_time, l->count),
> 
> Hmm... Why is the cast needed here?
> 
>> +                               l->max_time);
>> +               } else
>> +                       seq_printf(seq, " age=%ld",
>> +                               l->min_time);
> 
> ...
> 
>> +               if (num_online_cpus() > 1 &&
>> +                               !cpumask_empty(to_cpumask(l->cpus)))
> 
> One line?
> 
I have split the line because it is crossing the 80 columns. In this
case it's okay to cross 80 columns?
> ...
> 
>> +static const struct seq_operations slab_debugfs_sops = {
>> +       .start  = slab_debugfs_start,
>> +       .next   = slab_debugfs_next,
>> +       .stop   = slab_debugfs_stop,
> 
>> +       .show   = slab_debugfs_show
> 
> Leave a comma here. It might not be the last one in the future.
> 
>> +};
> 
> + blank line?
> 
>> +static int slab_debug_trace_open(struct inode *inode, struct file *filep)
>> +{
> 
> ...
> 
>> +static const struct file_operations slab_debugfs_fops = {
>> +       .open    = slab_debug_trace_open,
>> +       .read    = seq_read,
>> +       .llseek  = seq_lseek,
>> +       .release = slab_debug_trace_release,
>> +};
>> +
>> +
> 
> One blank line is enough.
> 
> ...
> 
>> +       debugfs_remove_recursive(debugfs_lookup(s->name,
>> +                                       slab_debugfs_root));
> 
> One line?
> 
Same here!