Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210603205047.GA2135380@bjorn-Precision-5520>
 <20210604170938.GA2218177@bjorn-Precision-5520> <CAJZ5v0iDxpYxz3_8RrWSJkM7cf=xS298agXcULm3EqRC++GD2g@mail.gmail.com>
 <YL4pq0oJyZfSWeTV@suse.de>
In-Reply-To: <YL4pq0oJyZfSWeTV@suse.de>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 7 Jun 2021 16:18:35 +0200
Message-ID: <CAJZ5v0iR-iar8BGwM7QgFEkqeRkZ=qn1PrKW0yxrERjDViUjaA@mail.gmail.com>
Subject: Re: [PATCH] PCI/APCI: Move acpi_pci_osc_support() check to
 negotiation phase
To:     Joerg Roedel <jroedel@suse.de>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Linux PCI <linux-pci@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 7, 2021 at 4:14 PM Joerg Roedel <jroedel@suse.de> wrote:
>
> On Mon, Jun 07, 2021 at 02:56:24PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Jun 4, 2021 at 7:09 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > >  If either "pcie_ports_disabled" or Linux doesn't support everything in
> > > ACPI_PCIE_REQ_SUPPORT, we will never evaluate _OSC at all, so
> > > the platform won't know that Linux has OSC_PCI_SEGMENT_GROUPS_SUPPORT,
> > > OSC_PCI_HPX_TYPE_3_SUPPORT, OSC_PCI_EXT_CONFIG_SUPPORT, etc.
> >
> > Right.
>
> Thanks Bjorn and Rafael. So I think the important thing to do is to
> issue at least one _OSC call even when Linux is not trying to take
> control of anything.
>
> I look into a clean way to do this and get the kernel messages right.
> One thing to change is probably only calculating 'control' if
> !pcie_ports_disabled in negotiate_os_control().

Please also see
https://lore.kernel.org/linux-acpi/93d783c4-4468-023b-193e-3fc6eca35445@redhat.com/
for possible clashes etc.