Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ernst, Justin" <justin.ernst@hpe.com>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        Frank Seidel <frank@f-seidel.de>,
        "David E. Box" <david.e.box@linux.intel.com>
CC:     Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Travis, Mike" <mike.travis@hpe.com>
Subject: RE: [PATCH 4/4] x86/platform/uv: Constify static attribute_group
 struct
Thread-Topic: [PATCH 4/4] x86/platform/uv: Constify static attribute_group
 struct
Thread-Index: AQHXWkrCbbcm8vXqoEqP+CNK2D209KsInr4w
Date:   Mon, 7 Jun 2021 14:34:58 +0000
Message-ID: <AT5PR8401MB1300493C7B3FF4533549019587389@AT5PR8401MB1300.NAMPRD84.PROD.OUTLOOK.COM>
References: <20210605203807.60547-1-rikard.falkeborn@gmail.com>
 <20210605203807.60547-5-rikard.falkeborn@gmail.com>
In-Reply-To: <20210605203807.60547-5-rikard.falkeborn@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f5732867-06b5-44a3-755f-08d929c16d2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2021 14:34:58.5112
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ds+vf5U2qb1EZbn9IuHOkwU72XbkmTfp7/OOnbICKOUSCXDueQIFYwMb7Zz0fWFtLQBERFl9Fj43pyKB+09Miw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0369
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: cg3EFwZhjvQAd3AuEdH49FOww_liQxik
X-Proofpoint-ORIG-GUID: cg3EFwZhjvQAd3AuEdH49FOww_liQxik
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-06-07_11:2021-06-04,2021-06-07 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0
 mlxlogscore=999 malwarescore=0 mlxscore=0 clxscore=1011 bulkscore=0
 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2104190000 definitions=main-2106070106
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The only use of base_attr_group and hubless_base_attr_group is to pass
> their addresses to sysfs_create_group() and sysfs_remove_group(), both
> which takes pointers to const attribute_group structs. Make them const
> to allow the compiler to put them in read-only memory.
>=20
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Thank you for the patch.=20

Reviewed-by: Justin Ernst <justin.ernst@hpe.com>

> ---
>  drivers/platform/x86/uv_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sy=
sfs.c
> index 7badcfa3f384..956a354b57c1 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -778,7 +778,7 @@ static struct attribute *base_attrs[] =3D {
>  	NULL,
>  };
>=20
> -static struct attribute_group base_attr_group =3D {
> +static const struct attribute_group base_attr_group =3D {
>  	.attrs =3D base_attrs
>  };
>=20
> @@ -823,7 +823,7 @@ static struct attribute *hubless_base_attrs[] =3D {
>  	NULL,
>  };
>=20
> -static struct attribute_group hubless_base_attr_group =3D {
> +static const struct attribute_group hubless_base_attr_group =3D {
>  	.attrs =3D hubless_base_attrs
>  };
>=20
> --
> 2.31.1