Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] platform/x86: hdaps: Constify static attribute_group
 struct
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        "David E. Box" <david.e.box@linux.intel.com>,
        Justin Ernst <justin.ernst@hpe.com>,
        Frank Seidel <frank@f-seidel.de>
Cc:     Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mike Travis <mike.travis@hpe.com>
References: <20210605203807.60547-1-rikard.falkeborn@gmail.com>
 <20210605203807.60547-2-rikard.falkeborn@gmail.com>
From:   Frank Seidel <frank@f-seidel.de>
Message-ID: <5f39a247-25ce-03b0-21f2-506bae576117@f-seidel.de>
Date:   Mon, 7 Jun 2021 18:21:09 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210605203807.60547-2-rikard.falkeborn@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: de-DE
Precedence: bulk

> The only use of hdaps_attribute_group is to pass its address to
> sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> to const attribute_group structs. Make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Thanks for the patch and keeping me informed.

Reviewed-by: Frank Seidel <frank@f-seidel.de>

> ---
>   drivers/platform/x86/hdaps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> index a72270932ec3..9996485f5295 100644
> --- a/drivers/platform/x86/hdaps.c
> +++ b/drivers/platform/x86/hdaps.c
> @@ -462,7 +462,7 @@ static struct attribute *hdaps_attributes[] = {
>   	NULL,
>   };
>   
> -static struct attribute_group hdaps_attribute_group = {
> +static const struct attribute_group hdaps_attribute_group = {
>   	.attrs = hdaps_attributes,
>   };
>   
>