Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1622996045-25826-1-git-send-email-faiyazm@codeaurora.org>
 <CAHp75VdM0aziN4zHaf6=z6D0Nb=+GTbjV1pdTpRZ=yxGDZRkhw@mail.gmail.com> <d5c16162-91af-40ba-66dc-02ac5a6a48ef@codeaurora.org>
In-Reply-To: <d5c16162-91af-40ba-66dc-02ac5a6a48ef@codeaurora.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 7 Jun 2021 19:42:32 +0300
Message-ID: <CAHp75VeCLyOSExxLGSaTzR3OgE+_PGe4FxraCK8T3sn6yS6-uQ@mail.gmail.com>
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs
To:     Faiyaz Mohammed <faiyazm@codeaurora.org>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <greg@kroah.com>, glittao@gmail.com,
        vinmenon@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 7, 2021 at 4:55 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:

...

> >> +               if (num_online_cpus() > 1 &&
> >> +                               !cpumask_empty(to_cpumask(l->cpus)))
> >
> > One line?
> >
> I have split the line because it is crossing the 80 columns. In this
> case it's okay to cross 80 columns?

For how many characters? If it's 3 or 4 or so, it's fine to have it on
one line. Use common sense here.

...

> >> +       debugfs_remove_recursive(debugfs_lookup(s->name,
> >> +                                       slab_debugfs_root));
> >
> > One line?
> >
> Same here!

Same here.

-- 
With Best Regards,
Andy Shevchenko