Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030244AbWKEFax (ORCPT ); Sun, 5 Nov 2006 00:30:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030254AbWKEFax (ORCPT ); Sun, 5 Nov 2006 00:30:53 -0500 Received: from gate.crashing.org ([63.228.1.57]:32190 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1030244AbWKEFav (ORCPT ); Sun, 5 Nov 2006 00:30:51 -0500 Subject: Re: lib/iomap.c mmio_{in,out}s* vs. __raw_* accessors From: Benjamin Herrenschmidt To: Linus Torvalds Cc: Russell King , Linux Kernel list , Jeff Garzik , Andrew Morton , "David S. Miller" , Paul Mackerras In-Reply-To: <1162703335.28571.159.camel@localhost.localdomain> References: <1162626761.28571.14.camel@localhost.localdomain> <20061104140559.GC19760@flint.arm.linux.org.uk> <1162678639.28571.63.camel@localhost.localdomain> <1162689005.28571.118.camel@localhost.localdomain> <1162697533.28571.131.camel@localhost.localdomain> <1162699255.28571.150.camel@localhost.localdomain> <1162701537.28571.156.camel@localhost.localdomain> <1162703335.28571.159.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 05 Nov 2006 16:28:48 +1100 Message-Id: <1162704529.28571.164.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 On Sun, 2006-11-05 at 16:08 +1100, Benjamin Herrenschmidt wrote: > > Can you work based on something like this instead? > > > > (Totally untested, I just did this as an example of what I think is a lot > > more maintainable) > > Yup, that would definitely work for me. > > I'll do the same for the repeat ops.. I'm blind, didn't see you did it for them already :-) Ok, your patch builds fine here. I can't test at the moment as I don't have a machine at hand that has a device whose driver uses the ops in iomap though, but I can't see any reason why it wouldn't work if it builds, so as far as I'm concerned, that's good to go in 2.6.20. (earlier if you wish but I won't submit the patch doing the powerpc changes that makes me use those change before 2.6.20 obviously :-) Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/