Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4a76d2152f016b58298bec16aa2003a6ec55f8a8.camel@redhat.com>
Subject: Re: [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs
From:   Benjamin Berg <bberg@redhat.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 07 Jun 2021 22:09:58 +0200
In-Reply-To: <20210607131442.20121-1-heikki.krogerus@linux.intel.com>
References: <20210607131442.20121-1-heikki.krogerus@linux.intel.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-MwjrE0nA8w0YwPPjLjiH"
User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) 
MIME-Version: 1.0
Precedence: bulk


--=-MwjrE0nA8w0YwPPjLjiH
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Heikki,

On Mon, 2021-06-07 at 16:14 +0300, Heikki Krogerus wrote:
> This is the RFC series I promised [1].

Cool.

> I'm sorry it took this long to prepare these. I had to concentrate on
> other task for a while.
>=20
> Let me know if you still see any problems.

Hmm, I am not sure this got better. I applied the patchset on top of of
the 5.12.9 Fedora 34 kernel. On the machine in question (X1 Carbon 8),
I see the online state getting stuck at 1 occasionally. This can happen
for example when quickly plugging and unplugging a USB-C charger.

Benjamin

> [1]  =20
> https://lore.kernel.org/linux-usb/YKT3oEt%2F9fX8k8mw@kuha.fi.intel.com/
>=20
> thanks,
>=20
> Heikki Krogerus (7):
> =C2=A0 usb: typec: ucsi: Always cancel the command if PPM reports BUSY
> =C2=A0=C2=A0=C2=A0 condition
> =C2=A0 usb: typec: ucsi: Don't stop alt mode registration on busy
> condition
> =C2=A0 usb: typec: ucsi: Add poll worker for alternate modes
> =C2=A0 usb: typec: ucsi: acpi: Reduce the command completion timeout
> =C2=A0 usb: typec: ucsi: Process every connector change as unique
> connector
> =C2=A0=C2=A0=C2=A0 state
> =C2=A0 usb: typec: ucsi: Filter out spurious events
> =C2=A0 usb: typec: ucsi: Read the PDOs in separate work
>=20
> =C2=A0drivers/usb/typec/ucsi/ucsi.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 317 +=
+++++++++++++++-----------
> --
> =C2=A0drivers/usb/typec/ucsi/ucsi.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=
=C2=A0 3 +-
> =C2=A0drivers/usb/typec/ucsi/ucsi_acpi.c |=C2=A0=C2=A0 2 +-
> =C2=A03 files changed, 183 insertions(+), 139 deletions(-)
>=20


--=-MwjrE0nA8w0YwPPjLjiH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAmC+fRYACgkQq6ZWhpmF
Y3A0dQ//fF8Sa9KqO64UQxKOGPoxvIYm2XOKF+kHnJw/x6cMOXoJC7l0iHUAhVaK
QeyMmpH886ivLVwsFj2wW9nUL9jT8M4iGOqlW5PNku4li0yanl291M6lBAwL7VMm
iQAqsDaP66ARdcoHK/Fj6lauVmPzDQEsRcWkRx96hHLjbYX5H2EsOGLOpuTIKKaz
dWPV4NTY9TWjD8t4yBkwc5mVQULalYlB/qnofbFsHqujCdN/pyGQ4gSGeBSQKSnE
xV6ko35MyGwpeN0bxu3V2ga4+KLyKwdWx0GBo+qdELmSfJQGe4Lk5b10AePd2MA2
ZSH2jiFdySHz6kkxOZgYSlAonNFBq3zYSgMze9MrK5GWUAgknnH264Y0dE0HQ+cS
89AsOq2iOFP1D8eC+AZpI7Zofbh9RkmeHoDXQk2tXCRKte86G9Eb1G/zrAMxJIme
l/SzVDOuUy4SbHgppkhS9xCTX8S4vUczRx2GeHtX1HGl7seKzYLUtx/TlJG1Cz2h
klK+oZN/TXMmPkrDlIQK4UpF61+UkgqayfpD0wGEMYX7U1CIOVYS3pnXSvI/7w4V
PPeqCsKDj5+VmX1IU9X77/+tTavjAAI6jAw/fczgiaJebiM6YGdHODmU1ke7i72t
cdHPxELHcBP9aoJCmP2Cf32/SdKkaLEO9HuHJA++PhqqxqDJkyM=
=BuYK
-----END PGP SIGNATURE-----

--=-MwjrE0nA8w0YwPPjLjiH--