Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Jun 2021 14:59:06 -0700
From:   Moritz Fischer <mdf@kernel.org>
To:     trix@redhat.com
Cc:     hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] fpga: wrappers for fpga_manager_ops
Message-ID: <YL6WqqUYHkhj+tEj@epycbox.lan>
References: <20210607172402.2938697-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210607172402.2938697-1-trix@redhat.com>
Precedence: bulk

Hi Tom,

On Mon, Jun 07, 2021 at 10:23:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> As followup from
> https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@redhat.com/
> 
> Boards should not be required to have noop functions.
> So improve or create fpga-mgr wrappers for the fpga_manager_ops.  
> Remove the noop functions.
> Refactor fpga-mgr to use the wrappers.
> 
> write_sg op was not wrapped on purpose.  Its checking / use in
> fpga_mgr_buf_load_sg() did not warrant a wrapper.
> 
> Tom Rix (7):
>   fpga: wrap the write_init() op
>   fpga: make write_complete() op optional
>   fpga: wrap the write() op
>   fpga: wrap the status() op
>   fpga: wrap the state() op
>   fpga: wrap the fpga_remove() op
>   fpga: collect wrappers and change to inline
> 
>  drivers/fpga/dfl-fme-mgr.c   |   6 ---
>  drivers/fpga/fpga-mgr.c      | 102 +++++++++++++++++++++++------------
>  drivers/fpga/stratix10-soc.c |   6 ---
>  drivers/fpga/ts73xx-fpga.c   |   6 ---
>  drivers/fpga/zynqmp-fpga.c   |   7 ---
>  5 files changed, 67 insertions(+), 60 deletions(-)
> 
> -- 
> 2.26.3
> 

Thanks for doing this, will take a look tonight!

- Moritz