Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <91eef5ab3143ae8fadb8eb2969aecba5f3e7ad98.camel@perches.com>
Subject: Re: [PATCH][next] Input: Fix fall-through warning for Clang
From:   Joe Perches <joe@perches.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, Kees Cook <keescook@chromium.org>
Date:   Mon, 07 Jun 2021 15:02:40 -0700
In-Reply-To: <20210607214852.GA65141@embeddedor>
References: <20210607214852.GA65141@embeddedor>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-06-07 at 16:48 -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> warning by explicitly adding a fallthrough; statement.
[]
> diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c
[]
> @@ -660,6 +660,7 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
> ?					fallthrough;
> ?				case 45:				/* Ambiguous packet length */
> ?					if (j <= 40) {			/* ID length less or eq 40 -> FSP */
> +					fallthrough;
> ?				case 43:
> ?						sw->type = SW_ID_FSP;
> ?						break;

Yuck.  Super ugly.  There's no need to play games with indentation.

Perhaps the simpler:

				case 43:
					sw->type = SW_ID_FSP;
					break;
				case 45:				/* Ambiguous packet length */
					if (j <= 40) {			/* ID length less or eq 40 -> FSP */
						sw->type = SW_ID_FSP;
						break;
					}
					sw->number++;
					fallthrough;