Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] capability: fix doc warnings in capability.c
To:     "Serge E. Hallyn" <serge@hallyn.com>
CC:     <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <weiyongjun1@huawei.com>,
        <yuehaibing@huawei.com>, <yangjihong1@huawei.com>,
        <yukuai3@huawei.com>, <libaokun1@huawei.com>
References: <20210605062602.678602-1-libaokun1@huawei.com>
 <20210607230913.GA12581@mail.hallyn.com>
From:   "libaokun (A)" <libaokun1@huawei.com>
Message-ID: <83a6dfaa-80ef-62ba-313b-fff03efc6d9d@huawei.com>
Date:   Tue, 8 Jun 2021 09:14:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210607230913.GA12581@mail.hallyn.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thank you for your advice.

I didn't notice the order of the parameters.

I'm about to send a patch v2 with the changes suggested by you.

?? 2021/6/8 7:09, Serge E. Hallyn д??:
> On Sat, Jun 05, 2021 at 02:26:02PM +0800, Baokun Li wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> kernel/capability.c:490: warning: Function parameter or
>>   member 'mnt_userns' not described in 'privileged_wrt_inode_uidgid'
>> kernel/capability.c:506: warning: Function parameter or
>>   member 'mnt_userns' not described in 'capable_wrt_inode_uidgid'
>>
>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
>> ---
>>   kernel/capability.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/kernel/capability.c b/kernel/capability.c
>> index 46a361dde042..27a959aa897f 100644
>> --- a/kernel/capability.c
>> +++ b/kernel/capability.c
>> @@ -480,6 +480,7 @@ EXPORT_SYMBOL(file_ns_capable);
>>   /**
>>    * privileged_wrt_inode_uidgid - Do capabilities in the namespace work over the inode?
>>    * @ns: The user namespace in question
>> + * @mnt_userns: User namespace of the mount the inode was found from
>>    * @inode: The inode in question
>>    *
>>    * Return true if the inode uid and gid are within the namespace.
>> @@ -495,6 +496,7 @@ bool privileged_wrt_inode_uidgid(struct user_namespace *ns,
>>   /**
>>    * capable_wrt_inode_uidgid - Check nsown_capable and uid and gid mapped
>>    * @inode: The inode in question
>> + * @mnt_userns: User namespace of the mount the inode was found from
> The mnt_userns comes before the inode in this fn.
>
>>    * @cap: The capability in question
>>    *
>>    * Return true if the current task has the given capability targeted at
>> -- 
>> 2.31.1
> .