Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vMW+UB9Ue7wEWTDXi5Yp5feF8nm2PW8OlB6A97Tqc3uj03GNN9cbh0PDnZLGB49eAmBQ2av7BK
 D2N1/HfUk5mg==
IronPort-SDR: maRWrmr4eAl9j4yK/dNJ7RZrD+zeMCLt6Sj/28SnCBQ/6FdHVbeu6IuxAg+5lZG/4rlqqaRFPr
 T0xbo63sVbKQ==
Date:   Tue, 8 Jun 2021 09:54:07 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Benjamin Berg <bberg@redhat.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs
Message-ID: <YL8UD+nlBSSQGIMO@kuha.fi.intel.com>
References: <20210607131442.20121-1-heikki.krogerus@linux.intel.com>
 <4a76d2152f016b58298bec16aa2003a6ec55f8a8.camel@redhat.com>
 <YL8RPiVsEFOM9PBo@kuha.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YL8RPiVsEFOM9PBo@kuha.fi.intel.com>
Precedence: bulk

On Tue, Jun 08, 2021 at 09:42:09AM +0300, Heikki Krogerus wrote:
> On Mon, Jun 07, 2021 at 10:09:58PM +0200, Benjamin Berg wrote:
> > Hi Heikki,
> > 
> > On Mon, 2021-06-07 at 16:14 +0300, Heikki Krogerus wrote:
> > > This is the RFC series I promised [1].
> > 
> > Cool.
> > 
> > > I'm sorry it took this long to prepare these. I had to concentrate on
> > > other task for a while.
> > > 
> > > Let me know if you still see any problems.
> > 
> > Hmm, I am not sure this got better. I applied the patchset on top of of
> > the 5.12.9 Fedora 34 kernel. On the machine in question (X1 Carbon 8),
> > I see the online state getting stuck at 1 occasionally. This can happen
> > for example when quickly plugging and unplugging a USB-C charger.
> 
> Please check does the partner device get removed. What do you have
> under /sys/class/typec after that happens?

Oh yes. Could you also share the trace output when that happens?

        cd /sys/kernel/debug/tracing
        echo 1 > events/ucsi/enable
        # now reproduce the issue
        cat trace > ucsi.trace

thanks,

-- 
heikki