Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To:     "axel.lin@ingics.com" <axel.lin@ingics.com>,
        "broonie@kernel.org" <broonie@kernel.org>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        linux-power <linux-power@fi.rohmeurope.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: bd71815: Get rid of struct bd71815_pmic
Thread-Topic: [PATCH] regulator: bd71815: Get rid of struct bd71815_pmic
Thread-Index: AQHXW6mhfdAkSdVbgU2CGPMkDmSD/KsJvxiA
Date:   Tue, 8 Jun 2021 07:52:38 +0000
Message-ID: <5ac9821151fc80e7cdcf0c524e73851e61eaafe2.camel@fi.rohmeurope.com>
References: <20210607143002.1600017-1-axel.lin@ingics.com>
In-Reply-To: <20210607143002.1600017-1-axel.lin@ingics.com>
Reply-To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Accept-Language: fi-FI, en-US
Content-Language: en-US
user-agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-Q3zJhFgF3blQIFpwq4RE"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8f4782-9ccb-493f-47c3-08d92a5262cf
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2021 07:52:38.1313
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 94f2c475-a538-4112-b5dd-63f17273d67a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZzQuZZw4Ak0vpuXMS3T0mw6Bfebbc/lYswxPYs+T0PzKKs1tChlQrg4FEV7Qxkud07xfcOOgM8mSE6DNsa3mW3OlSV8vIuaDC3cGZHvhfOyle8Xui9WpcnJQAEYtVyAt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0301MB2282
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-Q3zJhFgF3blQIFpwq4RE
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


On Mon, 2021-06-07 at 22:30 +0800, Axel Lin wrote:
> The content of bd71815_regulators is never changed, no need to
> duplicate
> it, thus remove descs[BD71815_REGULATOR_CNT].
> The *regmap, *dev and *rdev[BD71815_REGULATOR_CNT] are not really
> needed.
> The *gps is unused.
>=20
> Thus the struct bd71815_pmic can be removed.
>=20
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/bd71815-regulator.c | 57 +++++++++--------------
> ----
>  1 file changed, 19 insertions(+), 38 deletions(-)

Thanks a lot Axel. This is nice!

We might need to decide the ops for LDO3 based on a DT configuration
because the LDO3 state can be tied to DCIN connection. Currently the
driver does not support that though - and this patch is a nice
simplification!

Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Best Regards
	--Matti


--=-Q3zJhFgF3blQIFpwq4RE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmC/IbUACgkQeFA3/03a
ocVuxggAhHe4s038FEz5w4fqtE+G2kvl/eqYwVtH8hUHwDr5p16SktPCTUIObpDN
FIPDEkerelHMqqammpZq0agrANTR3b4Gmg4qYbYXNJHwUIV8Xg4b9uFUiX+gQZce
Vgpz5OenvQr0b0GwFYt+QaSKATM8X1N2LEn73WzWCn8j6tyVkNidL7kOrF2/q5oY
aLxaW712OzdutM4mIbuy9zasE09SJUGhtr+LX1wGsTRPuT+UJobQubfBnAVb9z7E
4XNXdFiKN3o/Q1+K8fN8bfIltTBnRgThchn7eic6sEtCRthsabfSdYEgRYYTQPpB
4i+LetUUXWy1LEMEEV66loa9xy67Vg==
=S4vq
-----END PGP SIGNATURE-----

--=-Q3zJhFgF3blQIFpwq4RE--