Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Jun 2021 11:00:06 +0300
From:   Pavel Skripkin <paskripkin@gmail.com>
To:     Haakon Bugge <haakon.bugge@oracle.com>
Cc:     Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        "rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "syzbot+5134cdf021c4ed5aaa5f@syzkaller.appspotmail.com" 
        <syzbot+5134cdf021c4ed5aaa5f@syzkaller.appspotmail.com>
Subject: Re: [PATCH] net: rds: fix memory leak in rds_recvmsg
Message-ID: <20210608110006.5dbca106@gmail.com>
In-Reply-To: <CF68E17D-CC8A-4B30-9B67-4A0B0047FCE1@oracle.com>
References: <20210607194102.2883-1-paskripkin@gmail.com>
        <CF68E17D-CC8A-4B30-9B67-4A0B0047FCE1@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 8 Jun 2021 07:11:27 +0000
Haakon Bugge <haakon.bugge@oracle.com> wrote:

>=20
>=20
> > On 7 Jun 2021, at 21:41, Pavel Skripkin <paskripkin@gmail.com>
> > wrote:
> >=20
> > Syzbot reported memory leak in rds. The problem
> > was in unputted refcount in case of error.
> >=20
> > int rds_recvmsg(struct socket *sock, struct msghdr *msg, size_t
> > size, int msg_flags)
> > {
> > ...
> >=20
> > 	if (!rds_next_incoming(rs, &inc)) {
> > 		...
> > 	}
> >=20
> > After this "if" inc refcount incremented and
> >=20
> > 	if (rds_cmsg_recv(inc, msg, rs)) {
> > 		ret =3D -EFAULT;
> > 		goto out;
> > 	}
> > ...
> > out:
> > 	return ret;
> > }
> >=20
> > in case of rds_cmsg_recv() fail the refcount won't be
> > decremented. And it's easy to see from ftrace log, that
> > rds_inc_addref() don't have rds_inc_put() pair in
> > rds_recvmsg() after rds_cmsg_recv()
> >=20
> > 1)               |  rds_recvmsg() {
> > 1)   3.721 us    |    rds_inc_addref();
> > 1)   3.853 us    |    rds_message_inc_copy_to_user();
> > 1) + 10.395 us   |    rds_cmsg_recv();
> > 1) + 34.260 us   |  }
> >=20
> > Fixes: bdbe6fbc6a2f ("RDS: recv.c")
> > Reported-and-tested-by:
> > syzbot+5134cdf021c4ed5aaa5f@syzkaller.appspotmail.com
> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>=20
> Thank for your commit and analyses. One small nit below.
>=20
> > ---
> > net/rds/recv.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/net/rds/recv.c b/net/rds/recv.c
> > index 4db109fb6ec2..3fa16c339bfe 100644
> > --- a/net/rds/recv.c
> > +++ b/net/rds/recv.c
> > @@ -714,7 +714,7 @@ int rds_recvmsg(struct socket *sock, struct
> > msghdr *msg, size_t size,
> >=20
> > 		if (rds_cmsg_recv(inc, msg, rs)) {
> > 			ret =3D -EFAULT;
> > -			goto out;
> > +			goto out_put;
>=20
> Would a simple "break;" do it here and no need for the next hunk?
>=20
>=20
> Thxs, H=C3=A5kon
>=20

Sure! I'll send v2 soon. Thank you for feedback :)


With regards,
Pavel Skripkin