Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3904631pxj; Tue, 8 Jun 2021 01:18:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk5GiS6ktNjPaR+GZd+FM+srBlTRKE0zejvsKgYZCMg9YZeCg1qEzQiSf2ttjZ5PW1cA1e X-Received: by 2002:aa7:c04d:: with SMTP id k13mr21363578edo.122.1623140329098; Tue, 08 Jun 2021 01:18:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623140329; cv=none; d=google.com; s=arc-20160816; b=JgBeIxEnzFTe0mYplZoGr6s0j5UJTVuCe2Em0W8u1/0/6UdKl/PKVFbWMEoUtjTmA5 NKWQff2BmVlV0Su0cu7DTnkV9rYsIMfzd0zRvTz8+DRm2wjOAeaP4iQA5FHHkQJGeCNP VYmkb9TQuG1/Tv3ZG1sGvB1d3ieLQ/BawBumDc/1ZR7iVicwsc+cof+C7IeG/qPG4eBt Zil3SIORqoXmbgVOJhz3aCKVQ91sYzqlqmJqx2eLTfnveFqZx5SzRyjSEM7719lYBK5D torKY6dhdTRAhK8ev7kMyyCOt3lhJ8pnEbqesV1WWPY/Eil57lWoFVc6fOp9W/5J1S2y KUig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=BnsdIDAYuXmioKksJSYGtZB2MMKtFv0mKehbDzl2UrA=; b=yiv8bIy5vu1ShPvgABB/fZO4/ZTr3Z6slb15JQyh0QybuUYpTmDSnmwf2wa/H89rnK P6RJaUdqkJhtuy+MXZEoVQ11YujOUDA1/4ejz16yXt3Fy71vFkK5LJJVNQrbAbe56qkP 5kUy4KxI71h8g2XF5vePKqUsMRWe3fKUp35dEBwfs2nqs1fwoT42Q17QS7SP6aagvs3T PfPKTG+SVcjynVrj3WJMi7ZND2HUoq4jyaitnF4psrhPOHadbIeJHYJt76wL4K3qcFi6 Y6mTw9Dg0rdmocFHS5MUssjwwUYUHYsRH3vlprsIv3HLB+jCUslHjpbQob4z/iK/wEqy lYKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm2si14382115edb.457.2021.06.08.01.18.25; Tue, 08 Jun 2021 01:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbhFHISG (ORCPT + 99 others); Tue, 8 Jun 2021 04:18:06 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8081 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230287AbhFHIRp (ORCPT ); Tue, 8 Jun 2021 04:17:45 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FzjfQ73M1zYrtv; Tue, 8 Jun 2021 16:13:02 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 16:15:52 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 8 Jun 2021 16:15:51 +0800 From: Guangbin Huang To: , , , , CC: , , , Subject: [PATCH net-next 09/16] net: farsync: fix the code style issue about macros Date: Tue, 8 Jun 2021 16:12:35 +0800 Message-ID: <1623139962-34847-10-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1623139962-34847-1-git-send-email-huangguangbin2@huawei.com> References: <1623139962-34847-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li Macros with complex values should be enclosed in parentheses. space required after that ',' . Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/wan/farsync.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index 075f50d..f2cd832 100644 --- a/drivers/net/wan/farsync.c +++ b/drivers/net/wan/farsync.c @@ -489,13 +489,13 @@ struct fst_card_info { */ #define WIN_OFFSET(X) ((long)&(((struct fst_shared *)SMC_BASE)->X)) -#define FST_RDB(C,E) readb ((C)->mem + WIN_OFFSET(E)) -#define FST_RDW(C,E) readw ((C)->mem + WIN_OFFSET(E)) -#define FST_RDL(C,E) readl ((C)->mem + WIN_OFFSET(E)) +#define FST_RDB(C, E) (readb((C)->mem + WIN_OFFSET(E))) +#define FST_RDW(C, E) (readw((C)->mem + WIN_OFFSET(E))) +#define FST_RDL(C, E) (readl((C)->mem + WIN_OFFSET(E))) -#define FST_WRB(C,E,B) writeb ((B), (C)->mem + WIN_OFFSET(E)) -#define FST_WRW(C,E,W) writew ((W), (C)->mem + WIN_OFFSET(E)) -#define FST_WRL(C,E,L) writel ((L), (C)->mem + WIN_OFFSET(E)) +#define FST_WRB(C, E, B) (writeb((B), (C)->mem + WIN_OFFSET(E))) +#define FST_WRW(C, E, W) (writew((W), (C)->mem + WIN_OFFSET(E))) +#define FST_WRL(C, E, L) (writel((L), (C)->mem + WIN_OFFSET(E))) /* Debug support */ -- 2.8.1