Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3925955pxj; Tue, 8 Jun 2021 02:02:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9glDPb0Pjdi5Z6htiWaAOvASWO7vCtosdfVQQFfJOHRepXABVJNwyFHC6yupcKXbR30dL X-Received: by 2002:aa7:d610:: with SMTP id c16mr24441130edr.207.1623142977358; Tue, 08 Jun 2021 02:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623142977; cv=none; d=google.com; s=arc-20160816; b=x/CvlXaCVCeX3QQjJXjAr/eO4FXNDpTLnxh4UiW5vApZXUO9sMWr3XHvEYXyz8U4Ju uqjEw60O8edO+8ALJUCNVLeSnKVwQWgn947XfEoGhJkH0jQXogluRLdojBPAwdlfOZnd Ds5ERXbZHnbesnI1y1f9tjKYmcHgUII3fX6vZy/RBqYTXQ+3u7UVpc2mrCNFMyLVrDRc GtEKRem7CY8HRkrWFModgBh2hAuzYzPwIGNuVqIVjbRzr13FFpd/SDsrqq6oCVDDdI5+ HG/OLHey/kkXIQD8pXDopOnj8mkDfgC8K36U12Vh1YN05TgLA1w3nU+gK7DyEPIQ9Wfp TotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jqgzjC2ldarnTGQEvWbargyiISLRl5LvHbedzo0nB0A=; b=URaczC1ggFsflftEPG2j3KBlZPNu9TxECF+rPCxsD2GSF9NJgU11jB5Lq+nt9ELyt4 m4j1kusoORi6wC0a6PrqxOwyeC110nVGJAzbveud0vD2nHi3ZmBEPLcy8iKOwZHIt8gz HWoY+9qmoSZI93+nf5L0m9AB9Rpr8CgBKZHpdzy3UWYYNlIjfffBBblfYX/YMHsYdXeg K+AljYUPc/8KWXfF7C2gIWNDNnhw92mnl9wghwgf6mx5/POdc/SDhPI+2D2uLo173nA4 A0YK0LAfQ0EG4Y5qZdXqx5BJV3WpUz7N7e1oRk0Hy56osT7z2u/0uJva1ZZ6YbhPwTbf HEmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FrgeXw3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si12088422ejo.265.2021.06.08.02.02.33; Tue, 08 Jun 2021 02:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FrgeXw3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbhFHJB0 (ORCPT + 99 others); Tue, 8 Jun 2021 05:01:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:58594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhFHJBX (ORCPT ); Tue, 8 Jun 2021 05:01:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D16C61153; Tue, 8 Jun 2021 08:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623142758; bh=jqgzjC2ldarnTGQEvWbargyiISLRl5LvHbedzo0nB0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FrgeXw3i0dDuqtcvKr3FiDk4xqPy/vxmHQTDRDQpiZZ8B2y/1Tdezqvs6eSHjIM3e LWRZ5EgGieHFzE5ei4ONB6JF4PA9CqmW+9hDE7gxWW9/+SU9vXKFBeqOThdueayjdV g0JHt3rQPvr1DG8+wKiQGHgtPgoCypfacbVOKQus= Date: Tue, 8 Jun 2021 10:59:13 +0200 From: Greg KH To: Chris Chiu Cc: Ricky WU , arnd@arndb.de, Bjorn Helgaas , ulf.hansson@linaro.org, rui_feng@realsil.com.cn, vaibhavgupta40@gmail.com, yang.lee@linux.alibaba.com, Linux Kernel Subject: Re: [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG Message-ID: References: <20210607101634.4948-1-ricky_wu@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 11:43:03AM +0800, Chris Chiu wrote: > On Mon, Jun 7, 2021 at 6:16 PM wrote: > > > > From: Ricky Wu > > > > aspm (Active State Power Management) > > rtsx_comm_set_aspm: this function is for driver to make sure > > not enter power saving when processing of init and card_detcct > > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250 > > Change back to use original way to control aspm > > ASPM_MODE_REG: 5227A 524A 5250A 5260 5261 5228 > > Keep the new way to control aspm > > > > Signed-off-by: Ricky Wu > > --- > Reported-by: Chris Chiu Can you test this to verify it works? thanks, greg k-h