Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3973995pxj; Tue, 8 Jun 2021 03:29:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9dGPGMW5x171VO99oS4Pw+bahPR8uRa4B2Hq6DCGOMLq7VfS6KJHqdg/UP9m9DAWZEzqk X-Received: by 2002:a17:907:1117:: with SMTP id qu23mr22753839ejb.71.1623148177948; Tue, 08 Jun 2021 03:29:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623148177; cv=none; d=google.com; s=arc-20160816; b=buHWtY7ZtJfaKJVopV6JSxP6hcbpPx8veQpldshvVVxi3mv7NcqY5vPN5vdwYQxDvp 3Od42eXgTstdaWDMZI6U0KniG9dEJw1V9vYnk8Tng4eprO2T3wtH0q6xbClYpj8uNZOI rXHbjEJ34UMXn8ZC2uVPs56Y74sB6go8oWpNP9zuVc0vhLd8Crk9Yn1FTWuw7H2FhOGo dnM9IkOcxIOkD3Va7DvIXxPMk5XX5xH1b8sCwGXrqASkT1CQO9l7b0iLOfFmfwMAMyhA mP80MaHwf+idVJSZgjAAJZH3GUwLoB39K/2jNfRqewiQgdsqnh0WtH+2LxjGP4NWqGe0 n43w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=oXQkD0DBoY5y6hIiz5rZLeOHQy3FLYfLuzScq5jv4No=; b=UkkxhYm5KReogQ7lziruLS0I0BG7v1IU8mfDNyjjV0HuGik789x76MY2GKThXOSep0 +d7bJP1L6w4bbAFfMsDwgpA6mdjGn1zbMqaO2XgHjaJnIYPcNa39d/sbaGhI3d13PXZi O4o7KNRwy84kJMZ+Ftn8ixN3sxLztynkSmjzG0jL3Sj+qQqY3lK70lUGDMHX/1LI4t+M 0TVPqazLZs1JMOSzrXP+VjBYsNKsFYRD4p9bGBoThwEC1YQn/pNkmNDxZdRRQ47I5dxp zM39WL+erKenRI2pdU0LEbGZBfma/a8r0OZoS61iryXpiW5yi+KWZGwBiXIEyuYEeWcK BBew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si14828287ede.460.2021.06.08.03.29.14; Tue, 08 Jun 2021 03:29:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbhFHK1q (ORCPT + 99 others); Tue, 8 Jun 2021 06:27:46 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:22455 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbhFHK1q (ORCPT ); Tue, 8 Jun 2021 06:27:46 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 158ABxpu009819; Tue, 8 Jun 2021 18:11:59 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from slee-VirtualBox.localdomain (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 18:25:48 +0800 From: Steven Lee To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list CC: , , , Subject: [PATCH v5 00/10] ASPEED sgpio driver enhancement. Date: Tue, 8 Jun 2021 18:25:35 +0800 Message-ID: <20210608102547.4880-1-steven_lee@aspeedtech.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 158ABxpu009819 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one with 80 pins, AST2500/AST2400 SoC has 1 SGPIO master interface that supports up to 80 pins. In the current driver design, the max number of sgpio pins is hardcoded in macro MAX_NR_HW_SGPIO and the value is 80. For supporting sgpio master interfaces of AST2600 SoC, the patch series contains the following enhancement: - Convert txt dt-bindings to yaml. - Update aspeed-g6 dtsi to support the enhanced sgpio. - Define max number of gpio pins in ast2600 platform data. Old chip uses the original hardcoded value. - Support muiltiple SGPIO master interfaces. - Support up to 128 pins. - Support wdt reset tolerance. - Fix irq_chip issues which causes multiple sgpio devices use the same irq_chip data. - Replace all of_*() APIs with device_*(). Changes from v4: * Remove ngpios from dtsi * Add ast2400 and ast2500 platform data. * Remove unused macros. * Add ngpios check in a separate patch. * Fix coding style issues. Changes from v3: * Split dt-bindings patch to 2 patches * Rename ast2600-sgpiom1 compatible with ast2600-sgiom-128 * Rename ast2600-sgpiom2 compatible with ast2600-sgiom-80 * Correct the typo in commit messages. * Fix coding style issues. * Replace all of_*() APIs with device_*(). Changes from v2: * Remove maximum/minimum of ngpios from bindings. * Remove max-ngpios from bindings and dtsi. * Remove ast2400-sgpiom and ast2500-sgpiom compatibles from dts and driver. * Add ast2600-sgpiom1 and ast2600-sgpiom2 compatibles as their max number of available gpio pins are different. * Modify functions to pass aspeed_sgpio struct instead of passing max_ngpios. * Split sgpio driver patch to 3 patches Changes from v1: * Fix yaml format issues. * Fix issues reported by kernel test robot. Please help to review. Thanks, Steven Steven Lee (10): dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. dt-bindings: aspeed-sgpio: Add ast2600 sgpio compatibles. ARM: dts: aspeed-g6: Add SGPIO node. ARM: dts: aspeed-g5: Remove ngpios from sgpio node. gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support gpio: gpio-aspeed-sgpio: Add AST2400 and AST2500 platform data. gpio: gpio-aspeed-sgpio: Add set_config function gpio: gpio-aspeed-sgpio: Move irq_chip to aspeed-sgpio struct gpio: gpio-aspeed-sgpio: Use generic device property APIs gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8. .../bindings/gpio/aspeed,sgpio.yaml | 78 +++++++ .../devicetree/bindings/gpio/sgpio-aspeed.txt | 46 ---- arch/arm/boot/dts/aspeed-g5.dtsi | 1 - arch/arm/boot/dts/aspeed-g6.dtsi | 28 +++ drivers/gpio/gpio-aspeed-sgpio.c | 206 ++++++++++++------ 5 files changed, 248 insertions(+), 111 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml delete mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt -- 2.17.1