Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210608202748.06334136@canb.auug.org.au>
In-Reply-To: <20210608202748.06334136@canb.auug.org.au>
From:   Hyunchul Lee <hyc.lee@gmail.com>
Date:   Tue, 8 Jun 2021 19:53:09 +0900
Message-ID: <CANFS6baQi_PDM+4XHNn6MnFtmvbP3JUDJJgw7fvkGDYja4=ELg@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the cifs tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Steve French <smfrench@gmail.com>,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Namjae Jeon <linkinjeon@kernel.org>
Cc:     CIFS <linux-cifs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

2021=EB=85=84 6=EC=9B=94 8=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 7:27, St=
ephen Rothwell <sfr@canb.auug.org.au>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_deco=
der+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spn=
ego_negtoken
> init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech=
'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this=
_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined h=
ere
> ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_m=
ech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg=
_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_ty=
pe+0x0): first defined here
>
> Caused by commit
>
>   4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")

I missed functions and structures generated from the ASN1 compiler
aren't static.

Steve, and Namjae,
We need to rename *.asn1 files and decoder's callback functions. Is it bett=
er
to change cifs's code?

Thanks,
Hyunchul

>
> interacting with commit
>
>   fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
>
> from the cifsd tree.
>
> I have reverted that cifs tree commit for today.
>
> --
> Cheers,
> Stephen Rothwell