Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4004601pxj; Tue, 8 Jun 2021 04:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwG9VLbuTrhf4IztEPJdEyf70nVHezMiFK59JqwmlB/xjyfOnRxB/fsi90TfXY0MtBbXx/Z X-Received: by 2002:a05:6402:3c1:: with SMTP id t1mr25246615edw.270.1623151106610; Tue, 08 Jun 2021 04:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623151106; cv=none; d=google.com; s=arc-20160816; b=gxYOS1KqpUiBeTPTWdTWrQ9ZIgS66vrND1YmTFMSoUz8lkWQZ8xPOyXDdZNHICssT3 UcOCdSo6T7k7YgxvhAzIsLRziKwQ6Tb4SBxfUsZtEvc96xFOgL3aYPBQcc2bkK9K6EOe BB5N/JVhk4jhqp/TmnWVvAkMEBpSfxxzZYv/KD0Qxk4r8bU52Y+aKQbWO6CEgdqs5i8v RTzKtEiWBGHT+TM2+85vdEeOXyUspGJfg2OTug3rrsZlB8iAzIWt/mFFDncgrnOPO2zO tbED7gNdyZnndy5EvJoihKVtA08uM3kEItceBJvV3WFHTuzO8AsFQWUVaaXHpLUOcgyd WjqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=+fsvskcwT6SL9LDQeWmhuuxMe+eVOopTvyaBeF6nBAk=; b=vzWwy8T3JoEp7xNO2l6wv+kdPrckhwE3EdpGeWkgNHCugsHLFPOyRYt2k0NXGkUeSm 4GZgPeSuakdl/Ohp86FGOBbZiFLdDzqNxgNPeawtDL29BsKxpRg9lFj8A8iLmlrP1M5O X8cK1cyOBQLUiSt2fRnLDsWSmeO84jXbSsxcE5ABr62mOT82Im1jiBwWfKW9xgpb6nP5 98RaofteV/heQgFFeBAtR91wJy6eOgWfRTYVJR3SZkvabypYCaxi4DRcI5wqkN/Hul3u NNk08idUgSpMP/zAm6oOeBh/+stJVXgCPBmoxk5j6j8t025vylALWBPFTdNJvZeCx0BT tyUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si15185319ejt.376.2021.06.08.04.18.03; Tue, 08 Jun 2021 04:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231751AbhFHLSU (ORCPT + 99 others); Tue, 8 Jun 2021 07:18:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58774 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbhFHLSU (ORCPT ); Tue, 8 Jun 2021 07:18:20 -0400 Received: from mail-oo1-f69.google.com ([209.85.161.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lqZic-0008Ay-NF for linux-kernel@vger.kernel.org; Tue, 08 Jun 2021 11:16:26 +0000 Received: by mail-oo1-f69.google.com with SMTP id n62-20020a4a53410000b0290246a4799849so12478962oob.8 for ; Tue, 08 Jun 2021 04:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+fsvskcwT6SL9LDQeWmhuuxMe+eVOopTvyaBeF6nBAk=; b=AWb3gQdClzJk4c4euuaca0vtD8bc38CYBkBy2ZbYdlH3cGLxhs3JgL8fCrWzRZ/oNn /yV91e124kKT6PDCQiQ0MJ8QmxHfOcZdkgoqcUD9vukZOB6QdXOduzKSC9Z4Dw2EVrmg CeuIeetBlXdR9D3DHnshmj7qMtffirjvXevR8pckkko+B2fci7HBTdNmEZHiaISRXJQy h6HDvsKlCCG7B4qtGnLwHEFANmrsN3bmj/HZIcXb4CRCQPcRgMHi1a+8QoL+KyiQhGGk rHJK2ZhPaxSuO8o0REMFP8zDOpTcZ4XR8cbP4utNRgAhNyqTdc/j5LEdedAi6pz13QR5 t8kg== X-Gm-Message-State: AOAM533vQnSiZs8kMafhsxlodwyDyJFJd4MiXyLRclmv88uSynUIzYuv 1N2cHUvH84p5a8TOEzdqHvXJTJ5Jn9+BUOnrcz6h7WUIedxBADg4WnKJfwksmGKtvxwS4vwkITF lhOqHvdgPsgRfWM5EBuaamVbiDvDf3dHsFlxyKs4OgkC3w7tE1emY3eHvyw== X-Received: by 2002:a05:6808:142:: with SMTP id h2mr2377053oie.169.1623150985701; Tue, 08 Jun 2021 04:16:25 -0700 (PDT) X-Received: by 2002:a05:6808:142:: with SMTP id h2mr2377037oie.169.1623150985425; Tue, 08 Jun 2021 04:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20210607101634.4948-1-ricky_wu@realtek.com> In-Reply-To: From: Chris Chiu Date: Tue, 8 Jun 2021 19:16:14 +0800 Message-ID: Subject: Re: [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG To: Greg KH Cc: Ricky WU , arnd@arndb.de, Bjorn Helgaas , ulf.hansson@linaro.org, rui_feng@realsil.com.cn, vaibhavgupta40@gmail.com, yang.lee@linux.alibaba.com, Linux Kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 8, 2021 at 4:59 PM Greg KH wrote: > > On Tue, Jun 08, 2021 at 11:43:03AM +0800, Chris Chiu wrote: > > On Mon, Jun 7, 2021 at 6:16 PM wrote: > > > > > > From: Ricky Wu > > > > > > aspm (Active State Power Management) > > > rtsx_comm_set_aspm: this function is for driver to make sure > > > not enter power saving when processing of init and card_detcct > > > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250 > > > Change back to use original way to control aspm > > > ASPM_MODE_REG: 5227A 524A 5250A 5260 5261 5228 > > > Keep the new way to control aspm > > > > > > Signed-off-by: Ricky Wu > > > --- > > Reported-by: Chris Chiu > > Can you test this to verify it works? > > thanks, > > greg k-h It's verified and confirmed by the user at comment #17 of https://bugs.launchpad.net/bugs/1929444.