Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4027444pxj; Tue, 8 Jun 2021 04:54:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaPz7sO/jBu8ncwe/KHgGFCq+KE+IMU5w8UziZISvulb1LN4DYVjZTbMrRBJFRKcCI5bVx X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr23044821ejc.400.1623153249319; Tue, 08 Jun 2021 04:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623153249; cv=none; d=google.com; s=arc-20160816; b=zP95K1/3yl2OyX5jFFvxlZMzwIM4Gl2jQMe70IsyBDhaWhv471ndmTq/NiRhOrg1GK wQrEtkUBA3J74fmPkAYS3hlT4iPNfMD5pruk+uPYdKgqaOU4WAztQPZOkFH7bJfCQStN QUvJzkoXY+9h+LLHYda/sfDHKbhd0V61RfS3h7Q+5AKJZNg6SxBEHEMvFvnapP6TrXww DCHPA9e0iWdwcF0oOwOR2H0UQFBfqVGDJaqahk4QoveQ0tF7B0HqZYZAh5bac+Y9mFo/ vtCFyOO9nlcxdtPA5WW6wcUxh4c5lXQZ81I5/lnVgmotW7QzIkqZoyGdAe2rS46rkcwV 6BhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=33qUIItaWV8iU0maz7SfEHZWO+xjznU3PiPkfVFxVEc=; b=XTcAghT/xiJuikgpgqrUQsNhNgHwXVO/p6+h1UW2IA8GJbBCzMflvNUKKmsywYM6KP f+rfPq7mwt8KdU3hgicDT6TXjCXY9UN4Wl0fWc8A2yCroO/2825xwQY7bkfIk8IxCt97 cePaXOfu2Uyvmq2eoB/vr357iU52UeReFRC3YgGuO942+um9y8pcl6o0vtQGIIdoG9NF qW7+HEqWHGsHayjg6QJNScte/8BJ8N++QFuLBgRVIZOF1FtmKVMdc7qHXEybstxvQHuh z+NmXz04h30JyFX858m5OyDugyogk/lKYt/ytmg/APcNQAUEsB4T0p4CfDM7FMsUnJBq MC5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ucvtPg+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gh14si14933884ejb.475.2021.06.08.04.53.45; Tue, 08 Jun 2021 04:54:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ucvtPg+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232122AbhFHLxr (ORCPT + 99 others); Tue, 8 Jun 2021 07:53:47 -0400 Received: from mail-pj1-f41.google.com ([209.85.216.41]:37380 "EHLO mail-pj1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbhFHLxq (ORCPT ); Tue, 8 Jun 2021 07:53:46 -0400 Received: by mail-pj1-f41.google.com with SMTP id 22-20020a17090a0c16b0290164a5354ad0so13918143pjs.2 for ; Tue, 08 Jun 2021 04:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=33qUIItaWV8iU0maz7SfEHZWO+xjznU3PiPkfVFxVEc=; b=ucvtPg+HlYZ8tqnZs6JrapTooEnRGmebxESXuGhQj0/kLP5o2dXv5i72CxBrG1QyEB Md1sjRo+ek617Y20+/qriDA/IO2hofnCiSY/mvwjhbwwsl92MwspA/HTQRQwJDscIc5q rSb7M/hu3KcP4DSRUCwLk05XBuw7vz9Vvq9OuuR/hr1u/xttgW2Cc9G3X4J+nBNppUBY +vMuL0ZsZtkfrOBsvYD8BZQ3/DgyMGZHdQlXMYVDnCJbZsnWpsvomtXVqOiq9ZGBeR6L /LbLKtpIQdScEXK7C+T4AgBvEXsMjq5rs96Hp0IgVJcrcJEU2nFsyAvhbrZJ8xWsn2Ch EDcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=33qUIItaWV8iU0maz7SfEHZWO+xjznU3PiPkfVFxVEc=; b=Jre3JgM0TbP6Oqlpj/wm0jHZzWvT5osvBTsf0RuO1wPU6UCojHLDMeXXSiKq0Z1/vB rOZsYadkj18AoQrUEpJ8kuWGMSoKou+YRmP0fD8aD16qd7RzQtRIqQyxjmYavniVwUdW jkXp7Gb4tru07bfzYU1D8z+yQ72UDey1M3fV8pKcdEKz6hNgG57nGOfaMiSMKQXcRRHR WJSskYdMne1oOQPY1X89L9obDNNbMwimk2AS60qug/dd4GSSRVFOwFGjstMIQMn59UfV 8LXv05Mg6rE/vtBkHeR/D6OXBmuyU1io5VyavHiaXkqfmliubJI9zasSdHEATLJje+/O 47Dw== X-Gm-Message-State: AOAM533XY5ohFC7vli9RrSulALorewsMudmGGBoplhMXmG1o1BzTQgcT FMqCFO7AUTBhRWz8x09WygwwNUEPF0b+qXAUy/w= X-Received: by 2002:a17:902:b190:b029:105:cb55:3a7a with SMTP id s16-20020a170902b190b0290105cb553a7amr18934867plr.17.1623153039020; Tue, 08 Jun 2021 04:50:39 -0700 (PDT) MIME-Version: 1.0 References: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> In-Reply-To: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> From: Andy Shevchenko Date: Tue, 8 Jun 2021 14:50:22 +0300 Message-ID: Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs To: Faiyaz Mohammed Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , linux-mm , Linux Kernel Mailing List , Greg KH , glittao@gmail.com, vinmenon@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed wrote: > > alloc_calls and free_calls implementation in sysfs have two issues, > one is PAGE_SIZE limitation of sysfs and other is it does not adhere > to "one value per file" rule. > > To overcome this issues, move the alloc_calls and free_calls > implementation to debugfs. > > Debugfs cache will be created if SLAB_STORE_USER flag is set. > > Rename the alloc_calls/free_calls to alloc_traces/free_traces, > to be inline with what it does. > > Signed-off-by: Faiyaz Mohammed > --- It seems you missed the version bump along with changelog. Note, some maintainers (actually quite many I think) are using tools to fetch up the patches and two patches with the same version is a problem. Hence I do not consider it a nit-pick. -- With Best Regards, Andy Shevchenko