Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4133423pxj; Tue, 8 Jun 2021 07:14:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1r6OU68PV3Nl53mxUv2PWp3yVHmbwKjtly9ViRjyX8E6AthCGo8Cl9AZ53SHFqHzNpVvv X-Received: by 2002:a17:906:70d4:: with SMTP id g20mr10778316ejk.327.1623161692097; Tue, 08 Jun 2021 07:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623161692; cv=none; d=google.com; s=arc-20160816; b=mzQImvIEqp/sqCXiP6EKo+QrcU4tNMiHCJWUn7e/iNjLqT9oK7SThVJ4u+J+KBLN3O uOeu99GsRswbefL66m1Cd/OP9mFRx2t9VTH4X60L7izv+bAybHtIaeMnG0t35SExVtt4 eVx5J//Fh23y3g9AZ6B6UZpTXoxyUqp2H4qTR72ewvJe9L6VjIVpxnvkz44fXejGvpYh Ra2YgdmnvdnxiSOAyctx4LlTPRiBYBwdmI69dxsQ5rpdsQW+2WuLLHo+/dCIPFYeKgf5 qPhr+SwxDq6T3SiD4LqTAv8z8BB8CwonW1ISBXGGyfJlKdyKmaE2nw2WFCrgyfzTgeDP iiMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=REfy8GVc7L4ILhiTgwJqezz9BmbpNaNFioLjXwH3o2s=; b=QHV0nMRYq7yGzbgcf9EGmglYkS6n4/E37Xo0BWIDcJrkNhPCwrB3IZRCA/wLaK9sRy 3KlBUOYgaNCDjtgGv32GUcB992qfXbHAU34rWOxp6aiXr9r9VJ7s9okmizJDcwjIzT5d 4kL8U5kRuJkta7tRiws0fU91x5XDWTSGfuHqurZ7+DsxMf75UnMnaB8bwQ+SyA8kxZ98 Kzrirk1uhgYCTpnq1Eh6dE09TaptLLR8DMFecsjoilPeRNkYPH4umb/kVGZEPPZfmXrT wXO1NR8/rDRDHd+tavXhnn4Kt10Xw7x5AeKFFtlwP2fEDRNlEiACmtPN3ajR7/cQQWQ7 M5EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nlECTdcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si7241919edq.545.2021.06.08.07.14.28; Tue, 08 Jun 2021 07:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nlECTdcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233241AbhFHOOZ (ORCPT + 99 others); Tue, 8 Jun 2021 10:14:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233230AbhFHOOX (ORCPT ); Tue, 8 Jun 2021 10:14:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EB3760FE9; Tue, 8 Jun 2021 14:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623161538; bh=UU78FkBvBQ+bGhsuFu7iJ2jbXBPQNaYDh0/ReT/swaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlECTdcCEFg8WxBNBWEoa6V4TQGTwh8v5XDRZSW0dYn0HwCk3tDynaAxsS8fPAGfc m9/LM9M/VMmepG/fc98rvp3VTg5ig7IMQVN42JLi85FtDPAhsyCbYQM9KnbKrMMR6u ORUayTW1zbBHEEvjcERoUtDbF3tIWuqGNJeAfRF0= Date: Tue, 8 Jun 2021 16:12:15 +0200 From: Greg Kroah-Hartman To: Liu Shixin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address Message-ID: References: <20210608141620.525521-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608141620.525521-1-liushixin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 10:16:20PM +0800, Liu Shixin wrote: > Use eth_broadcast_addr() to assign broadcast address. That says what you do, but not _why_ you are doing this? Why make this change? What benifit does it provide? thanks, greg k-h