Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161689AbWKET7G (ORCPT ); Sun, 5 Nov 2006 14:59:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161690AbWKET7G (ORCPT ); Sun, 5 Nov 2006 14:59:06 -0500 Received: from amsfep19-int.chello.nl ([213.46.243.16]:29053 "EHLO amsfep17-int.chello.nl") by vger.kernel.org with ESMTP id S1161689AbWKET7F (ORCPT ); Sun, 5 Nov 2006 14:59:05 -0500 Subject: Re: [PATCH 1/2] sunrpc: add missing spin_unlock From: Peter Zijlstra To: Andrew Morton Cc: riesebie@lxtec.de, Akinobu Mita , linux-kernel@vger.kernel.org, Andy Adamson , "J. Bruce Fields" , Trond Myklebust , Olaf Kirch In-Reply-To: <20061105114533.4f57f333.akpm@osdl.org> References: <20061028185554.GM9973@localhost> <20061029133551.GA10072@localhost> <20061029133700.GA10295@localhost> <1162744516.26989.43.camel@twins> <20061105114533.4f57f333.akpm@osdl.org> Content-Type: text/plain Date: Sun, 05 Nov 2006 20:58:59 +0100 Message-Id: <1162756740.14695.9.camel@lappy> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 49 On Sun, 2006-11-05 at 11:45 -0800, Andrew Morton wrote: > On Sun, 05 Nov 2006 17:35:16 +0100 > Peter Zijlstra wrote: > > > On Sun, 2006-10-29 at 22:37 +0900, Akinobu Mita wrote: > > > auth_domain_put() forgot to unlock acquired spinlock. > > > > > > Cc: Olaf Kirch > > > Cc: Andy Adamson > > > Cc: J. Bruce Fields > > > Cc: Trond Myklebust > > > Signed-off-by: Akinobu Mita > > > > Acked-by: Peter Zijlstra > > > > I just found this too while trying to get .19-rc4-git up and running on > > a machine here - took me a few hours. > > > > It made my kernel decidedly unhappy :-( > > > > Andrew, could you push this and: > > http://lkml.org/lkml/2006/11/3/109 > > into .19 still? - those patches are needed to make todays git happy on > > my machine. > > OK. Thanks! > I wonder if this will fix http://bugzilla.kernel.org/show_bug.cgi?id=7457 The scheduling while atomic part looks familiar, the rest not so. Worth giving it a shot though... On my machine it was the keventd workqueue that got messed up. I have some patches that: - add debug_show_held_locks(current) to might_sleep() and schedule() - check in_atomic() and lockdep_depth after each workqueue function and print the last function executed - name some 'old_style_spin_init' locks I'll post those patches after a cleanup... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/