Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4190011pxj; Tue, 8 Jun 2021 08:28:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwx3FBw4LTUtQsHUznEtgGLapOBNiwt7+1IpknxrWZuGEo0lL6pJR/8ch0I3T4kRskIyAb5 X-Received: by 2002:a05:6402:5256:: with SMTP id t22mr13333136edd.54.1623166137901; Tue, 08 Jun 2021 08:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623166137; cv=none; d=google.com; s=arc-20160816; b=aZS8Zt2D24bUrWE6hI9xkVoBRAILxv4SUqUxj8L4Aok7hrBSQMqnQiKfsZbi3eE37P 0kaF9iG97knqJizvOdm2TOi0jHfLCc3CNYdLNqs557ANmSCgyficiB+QXgz5ta6f66ep UgXZGyYgn4y9ztrkLFaXA3E//e3eTBVTWSnOwHEUbT4enjYc897J0CSGMK6H75HU70kN YeH6YUG76ALGbkKvgJT9q6iRwQOk5Sz0jnbtcTXdSjJsXVXE+V8dno0ukiei34BVnO2/ GDWpaiQBa7eVE8ucnktjfYtaZUfTbiHULQ79HzpVBF7zjVKm4hWh7UxqtCeiVfa6jbfL pgDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=jYLpiPCQZpM+0HyeyUk4ri/5ofGA2P0gEQQY/BP7RWM=; b=YAne3VtuxzMSLLtLtWa2l//3bnjzIINYmCif1ZJIiLkmwQlfyGo1Di23IxKhSEIBq4 gEvv+csI7mF+L/9P/cKaEQ5aP4W8qOFulO/LNePXbrhv1cSf9wzO+S8dEWZHJi0tLHXs iU6h07RjBmTV8KE4MW8p+IH2mgPdFZ3lsXQ4lszFtrUSm6ZlW9+zhRyspLqLq5FPMkF4 PgCAPbd70n2XKckKywq79WF2iBcAOY0epFhYBx5J949wjHZZStIuMiZRizvRxRwd3TBA mu/5pzr+kUQowf+0X7nBderMNE1gV8mTsBHpX/fNOhxP4Di5cekZQSwgI3H2/Fb0BnRe Vt+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=OCJHJhG9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e19si3116ejb.113.2021.06.08.08.28.33; Tue, 08 Jun 2021 08:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=OCJHJhG9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbhFHP3K (ORCPT + 99 others); Tue, 8 Jun 2021 11:29:10 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:29674 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbhFHP3I (ORCPT ); Tue, 8 Jun 2021 11:29:08 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 158F7rtn014083; Tue, 8 Jun 2021 17:27:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=jYLpiPCQZpM+0HyeyUk4ri/5ofGA2P0gEQQY/BP7RWM=; b=OCJHJhG9UpOQC1DJUAneIwnMrPUM9YBg7kSmvpxuiRBmK4rsDtkV0ne8MUCS4ibmM+3V MjiYSyzKIrPZ2MkX9uWAXlSGCM8bCGTGa2peEtx6FTY6t8/R6iKivt1WHSQTJobUqzE/ 8l1v3TW9HvQ0kaM7+CHyFGR4Vd4Ws8sN8CXY9tZkyD/DHbK75isVNLaQB1Jb2ZzHmRfc VheJmdXn9ULIu17ka056WcytpGFBcqRCuNvT21J3hEx1/p6hzM0dZxLOrgx1IO+0M0ek pdiuIKyxbc0IpUGHV5cI2sZdiQPhsn5YYyc6skD0f3AGbsAZHeobcfI/A9EOobUJZDNl Lg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 39257v2bxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Jun 2021 17:27:04 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6141210002A; Tue, 8 Jun 2021 17:27:03 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2F45B2291B0; Tue, 8 Jun 2021 17:27:03 +0200 (CEST) Received: from lmecxl0889.lme.st.com (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 17:27:02 +0200 Subject: Re: [PATCH 0/4] rpmsg: char: introduce the rpmsg-raw channel To: Mathieu Poirier CC: Bjorn Andersson , Ohad Ben-Cohen , linux-remoteproc , Linux Kernel Mailing List , , Julien Massot References: <20210607173032.30133-1-arnaud.pouliquen@foss.st.com> From: Arnaud POULIQUEN Message-ID: <3a554f3e-71c1-3073-038f-0a4f7cc2d94a@foss.st.com> Date: Tue, 8 Jun 2021 17:27:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-06-08_10:2021-06-04,2021-06-08 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On 6/8/21 4:26 PM, Mathieu Poirier wrote: > Hi Arnaud, > > Between remoteproc/RPMSG and CoreSight, I have 6 patchsets to review > (including some of your work) before getting to this one. As such it > will take a little while. No worries, i knew you have already some patchsets in your pipe. As i used this series to test the rpmsg_ctrl [1], both were ready at the same time. So i decided to push it because it can also help you to perform tests on the series [1]. [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=494021 Thanks, Arnaud > > Thanks, > Mathieu > > On Mon, 7 Jun 2021 at 11:30, Arnaud Pouliquen > wrote: >> >> Purpose: >> Allow the remote processor to instantiate a /dev/rpmsgX interface relying on the NS announcement >> of the "rpmsg-raw" service. >> This patchet is extracted from the series [1] with rework to add rpmsg_create_default_ept helper. >> >> >> Aim: >> There is no generic sysfs interface based on RPMsg that allows a user application to communicate >> with a remote processor in a simple way. >> The rpmsg_char dev solves a part of this problem by allowing an endpoint to be created on the >> local side. But it does not take advantage of the NS announcement mechanism implemented for some >> backends such as the virtio backend. So it is not possible to probe it from a remote initiative. >> Extending the char rpmsg device to support NS announcement makes the rpmsg_char more generic. >> By announcing a "rpmg-raw" service, the firmware of a remote processor will be able to >> instantiate a /dev/rpmsgX interface providing to the user application a basic link to communicate >> with it without any knowledge of the rpmsg protocol. >> >> Implementation details: >> - Register a rpmsg driver for the rpmsg_char driver, associated to the "rpmsg-raw" channel service. >> - In case of rpmsg char device instantiated by the rpmsg bus (on NS announcement) manage the >> channel default endpoint to ensure a stable default endpoint address, for communication with >> the remote processor. >> >> How to test it: >> - This series can be applied on git/andersson/remoteproc.git for-next branch (dc0e14fa833b) >> + the "Restructure the rpmsg char to decorrelate the control part" series[2] >> >> [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=475217 >> [2] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=483793 >> >> >> >> Arnaud Pouliquen (4): >> rpmsg: Introduce rpmsg_create_default_ept function >> rpmsg: char: Add possibility to create and reuse default endpoint >> rpmsg: char: Introduce the "rpmsg-raw" channel >> rpmsg: char: Return error if user tries to destroy a default endpoint. >> >> drivers/rpmsg/rpmsg_char.c | 92 +++++++++++++++++++++++++++++++++++--- >> drivers/rpmsg/rpmsg_core.c | 51 +++++++++++++++++++++ >> include/linux/rpmsg.h | 14 ++++++ >> 3 files changed, 151 insertions(+), 6 deletions(-) >> >> -- >> 2.17.1 >>