Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4211610pxj; Tue, 8 Jun 2021 09:00:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZf1LjUPn/RDe5+JGybgHGATdatlF9Y66rDPAMJY0pXimmBSrkPmDIhhe1wiyJF8q0fSbb X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr26607002edr.197.1623168001510; Tue, 08 Jun 2021 09:00:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623168001; cv=none; d=google.com; s=arc-20160816; b=DL6ol9v7g+/LIUQyTy9A5J2VaUzgTjKRG7qkR+xYy8A0SYE2zS9nxMBoXIA9l/3GA+ 9iyd2jCkdfo9Yx1vL8FXESj59mS5WS8VfVn+hgeljzpwEJzZLEBrZEepTItq8GLDI9Xg gDUGKz8/EiWtMyCxEwKtwpuD+sZJue/51THmtl4Psyu57l7uo8p2O/t3zkkikyO092r4 GpvlyvdJhpjMbZCk+4RJLPLy1QS6I7gkpZo9oo0opns1Kx2OPvSZyqfiMFLAw4iv3roa gnbjaFTPwmFRsFUW3vp5f/YOpw87mfxil7HHuCjdLN0mLJorjFbr9FS6NbANb0lCSGOP GKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=aZh/KJwO8W1tFE9F48++OjyHYLEODwVik0fvHY5TiCo=; b=xWcjBVgB5gQmSRg/8MBeCJaEbl+8ytsusfxodZdJisXQEtSw+iVSJQEaeBlSXEXCoV qCSwR4zzLUNw8L6Ud/UQufEURykDdrfTq17cnzCgGmoT8ASlcbxl1MRxnwhwrtUZOsZK Ouc4PfG8aePsQvjCxmVbFnRiMIA6fMOo3TpLwnQAMyTPG7A9mmpntLS9HDrX7BNKe6BW u8Gtm3lNcZ+oROcGmETvgpldwbKROcgMy4l2uBelQqjxvjkYKWF4P/LvTW0Sd8ztZH55 hZEyXd8EGvJ5DSxG7Aiv4bW6mtaqSsUkHup2t3bQDwHOSjASLqTCvPNHBCANnNsH9Tn+ co2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rjk4hJdu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 25si40594ejd.711.2021.06.08.08.59.37; Tue, 08 Jun 2021 09:00:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rjk4hJdu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232688AbhFHP5j (ORCPT + 99 others); Tue, 8 Jun 2021 11:57:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbhFHP5i (ORCPT ); Tue, 8 Jun 2021 11:57:38 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AA23C061574; Tue, 8 Jun 2021 08:55:34 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id i10so32868705lfj.2; Tue, 08 Jun 2021 08:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aZh/KJwO8W1tFE9F48++OjyHYLEODwVik0fvHY5TiCo=; b=rjk4hJdu1uU/8uWY4e0Sl7ziWtWOg5iYymqnyRzCip+mRccItnyJcYInxiXjVydbD8 BrQBldsl6aTZAN2JJpKDB4iau38AgYV/AVYnxDYA7jkaaoZ8VYuw0ZgCzSwjmeH4il7q MxOVIeBMrmjDroADas0r3YC0+HRUXdjZvj/aF6weP59aeCRaS0Fe61olQbRDvOpg8tDR IR8usPANQ3QW8CvtQyDSUmbXGXoowv3pzpq60TbVvja4nzSk3HFwAH7rJEO+ScMK1zyf sFwsXTH3PNP5xNUHCZL9VdzhWxydi6r7bQefGEYQDxIrmaCMBIVCfqiCZzeuvNgtwmKM wDKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aZh/KJwO8W1tFE9F48++OjyHYLEODwVik0fvHY5TiCo=; b=M02OAECjKHEejc8+ov8x1vEF72xXhEsWT4H/2AJJG29F6gA2f4hAa8MapwUC2FdKid JUNQrNTjEcemp4uXYRGeraisvvTLL+f0013DCRFPVbLj6cheTQl8HUIunDwmzQqxXf/I qIDEIheqqMuri0PDViE4DuE8c2XTD4EZakzbqhh0yIF9rbucB36hesrhi/7ROFSFKPfN W418kWpApAzR5hvwtm3j5I1KnVRhXkZMmZEWCW1VwiIRvq7dLu3l3fpafpD4TCXiNMXO 1lfh1Jlgdj7Wc9Cbeb2augS5LQQuL2yAoXO4cNhtbbC3BtAvq8VlTLzihdZ36nCyfacE hk5g== X-Gm-Message-State: AOAM533qKk6a9T9PKNexRn2WjE92su/iK5FGBecDqVmMqv/RUZRhicm5 DrYmtK3g1tVpf4/HtdFxv+/rQwKoKRs= X-Received: by 2002:a05:6512:3f81:: with SMTP id x1mr7872509lfa.426.1623167732643; Tue, 08 Jun 2021 08:55:32 -0700 (PDT) Received: from [192.168.1.102] ([31.173.86.136]) by smtp.gmail.com with ESMTPSA id t24sm15300ljj.97.2021.06.08.08.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 08:55:32 -0700 (PDT) Subject: Re: [PATCH net-next] sh_eth: Use devm_platform_get_and_ioremap_resource() To: Yang Yingliang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org References: <20210608135718.3009950-1-yangyingliang@huawei.com> From: Sergei Shtylyov Message-ID: <365de7ff-fb86-db19-0ad2-13355646c09b@gmail.com> Date: Tue, 8 Jun 2021 18:55:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210608135718.3009950-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 6/8/21 4:57 PM, Yang Yingliang wrote: > Use devm_platform_get_and_ioremap_resource() to simplify > code. > > Signed-off-by: Yang Yingliang Reviewed-by: Sergei Shtylyov Is my understanding correct that you tried to convert the ravb driver too (and failed)? MBR, Sergei