Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND] arm64: meson: select COMMON_CLK
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kevin Hilman <khilman@baylibre.com>
References: <20210429083823.59546-1-jbrunet@baylibre.com>
 <162008674673.40672.14279142646066453043.b4-ty@baylibre.com>
 <CAMuHMdVhrMNzuXkD9BQxPaiwS41bsOyJU_kwGYwk5ftto-AGBQ@mail.gmail.com>
 <1jczsw1fnj.fsf@starbuckisacylon.baylibre.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <7e70f485-1114-223a-e7cc-386795049e4c@baylibre.com>
Date:   Tue, 8 Jun 2021 18:38:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1jczsw1fnj.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 08/06/2021 18:32, Jerome Brunet wrote:
> 
> On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
>> Hi Jerome,
>>
>> On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote:
>>> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote:
>>>> This fix the recent removal of clock drivers selection.
>>>> While it is not necessary to select the clock drivers themselves, we need
>>>> to select a proper implementation of the clock API, which for the meson, is
>>>> CCF
>>>
>>> Applied, thanks!
>>>
>>> [1/1] arm64: meson: select COMMON_CLK
>>>       commit: aea7a80ad5effd48f44a7a08c3903168be038a43
>>>
>>> Best regards,
>>> --
>>> Kevin Hilman <khilman@baylibre.com>
>>
>> Why is this needed, and why would this make any difference?
>> COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in
>> arch/arm64/Kconfig selects it.
> 
> Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had
> problem with COMMON_CLK (or any other clock implementation) being
> selected. TBH, I don't remember it exactly ...
> 
> For sure this was a mistake.
> Neil, can you still drop it and do you need a revert ?
I can't drop it, it has already been merged.

Please send a revert and I'll push it for 5.14-rc fixes.

Neil

> 
>>
>> Gr{oetje,eeting}s,
>>
>>                         Geert
>