Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4317009pxj; Tue, 8 Jun 2021 11:19:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSBOxw4zUPE5NvD3xvuXE3Glu3l+eXPjwFD6KbRr82I8NNitW3vFT6MoB6Uag6iAfathH5 X-Received: by 2002:aa7:d801:: with SMTP id v1mr27220684edq.349.1623176396073; Tue, 08 Jun 2021 11:19:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623176396; cv=none; d=google.com; s=arc-20160816; b=k6UzHHEB2A8qtDtvfkLPBweXj4arbWJ5npl4JJpfkWdnhehkeKdIwNMSzrwH/TAQNE d2EqU5YTXw/SebqpsdPLvihGjr2LWgOCMEnf2IcSiK7CAy3CCyol4dTlFdI7fhPLvJYW mzpHhaJQmAtS9bLKJ6fXa7sP3VBRlc9ChUoX+M5ddCpazeXQ7/dvgp0FZbB9SO6UnxG5 5ywpXMSTfRZiKG3zcI0lJbS2JTknuR+bKteGCRRz76f+EIBy9iOYgk79y72OuV69nU+A bzMbdGQ1wLL3M02L3dA3rgZJgF4sBlkRINWo2t6YHWVABfsi/egqYGDsUy3L9aTANVrv ANbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Co//ogi0KDTBikV6nydb3Go2X95ksXSe8+9miI8T9iQ=; b=HfcsGgu5dvBMho3/yvetPzmBrPw8X2Q5zyjtydudadYw+8MLp30dA2OEkXG6N4bfKc HqqiDcoiH6TdOpi3O3Vb9XL/E9rD7cwLoKDUQ+rSXGTR43zUwxWo1ZwL/DM10G2KGkTo zqmGJcTMPs42MGJhUZC26T+A5WBtvBNfDr38a2Bh+IgC61bOYIBYAKDt6rYaoADRchUX BP1bKVQXULZBk4LMXfrZYRisY3UhF0+rMDlENKlj2so3/am7lbEBHADCFfPZGYczQgat csEba/dsWHwZp5pZXKNH2FNDI3OBQ7yNZRFEDK4T8mCD+j9qdbZeYYKZjwn6LQdzWVif sJ+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=XqG0jOqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d24si116658ejo.430.2021.06.08.11.19.31; Tue, 08 Jun 2021 11:19:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=XqG0jOqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233817AbhFHSTV (ORCPT + 99 others); Tue, 8 Jun 2021 14:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231652AbhFHSTV (ORCPT ); Tue, 8 Jun 2021 14:19:21 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1CBEC061574 for ; Tue, 8 Jun 2021 11:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Co//ogi0KDTBikV6nydb3Go2X95ksXSe8+9miI8T9iQ=; b=XqG0jOqyMCpsVnKu6OAOf7cesn E2JdDxB74rXo3x/fdJ0BvS0gKeX4k33xRx8wC9uGxxVTZVym9FQC5Y2MTpuJs70UmH2mLtDOrvx91 bKyb10iErePQdNSqez88N+ot10ovaWpWn9WhBjRo7GQBnjceqjtMwivxyVxr3Uagdff4QZ/QF9vgr d8jwpb9jiib0/c2daiqQNzBN9sGxLDfmXC6PnNiTjs5YsbhXOUTc797gqQ/RcL+bS/90l5JutDeqk u97O/WQvaOnEl3VYhGSaqiVr4f0SHJWNNjLZ/VK6d5IKL7HTX56PbO8F3k5lB7CYsF87cza87RzTr QghaaP/g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqgHq-004pSJ-40; Tue, 08 Jun 2021 18:17:21 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7418030018A; Tue, 8 Jun 2021 20:17:20 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5FE37201D304F; Tue, 8 Jun 2021 20:17:20 +0200 (CEST) Date: Tue, 8 Jun 2021 20:17:20 +0200 From: Peter Zijlstra To: Nathan Chancellor Cc: Nick Desaulniers , =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= , Josh Poimboeuf , lma@semihalf.com, Guenter Roeck , Juergen Gross , lb@semihalf.com, LKML , mbenes@suse.com, =?utf-8?B?UmFkb3PFgmF3?= Biernacki , upstream@semihalf.com, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , clang-built-linux , Sami Tolvanen Subject: Re: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls Message-ID: References: <20210604235046.w3hazgcpsg4oefex@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 10:29:56AM -0700, Nathan Chancellor wrote: > On 6/8/2021 10:22 AM, Peter Zijlstra wrote: > > Since it's a VM, can you use the gdb-stub to ask it where it's stuck? > > > > Unfortunately, this is the VM provided by the Windows Subsystem for Linux so > examining it is nigh-impossible :/ I am considering bisecting the transforms > that objtool does to try and figure out the one that causes the machine to > fail to boot or try to reproduce in a different hypervisor, unless you have > any other ideas. Does breaking Windows earn points similar to breaking the binary drivers? :-) :-) The below should kill this latest transform and would quickly confirm if the that is causing your problem. If that's not it, what was your last known working version? diff --git a/tools/objtool/check.c b/tools/objtool/check.c index e5947fbb9e7a..d0f231b9c5a1 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1857,10 +1857,10 @@ static int decode_sections(struct objtool_file *file) * Must be after add_special_section_alts(), since this will emit * alternatives. Must be after add_{jump,call}_destination(), since * those create the call insn lists. - */ ret = arch_rewrite_retpolines(file); if (ret) return ret; + */ return 0; }