Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194
Mime-Version: 1.0
Message-Id: <cd58659a-c3ec-427a-bf57-26fb8f61505c@www.fastmail.com>
In-Reply-To: <4635488d-b98b-330f-1485-fecfcf6e72ff@intel.com>
References: <cover.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <8a1d6930f784cb57c957cf20cea870947db91e05.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <fe05830e-e82b-f338-2ba1-02651cb8087e@intel.com>
 <YL+tfGOMWEvDJTwc@google.com>
 <42f6b603-7c21-28fa-b6ec-e53268aa6ff7@intel.com>
 <3afaebee-77dc-83ff-c397-aa64991c52be@linux.intel.com>
 <4635488d-b98b-330f-1485-fecfcf6e72ff@intel.com>
Date:   Tue, 08 Jun 2021 11:17:47 -0700
From:   "Andy Lutomirski" <luto@kernel.org>
To:     "Dave Hansen" <dave.hansen@intel.com>,
        "Andi Kleen" <ak@linux.intel.com>,
        "Sean Christopherson" <seanjc@google.com>
Cc:     "Sathyanarayanan Kuppuswamy" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Tony Luck" <tony.luck@intel.com>,
        "Kirill Shutemov" <kirill.shutemov@linux.intel.com>,
        "Kuppuswamy Sathyanarayanan" <knsathya@kernel.org>,
        "Raj Ashok" <ashok.raj@intel.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 08/32] x86/traps: Add #VE support for TDX guest
Content-Type: text/plain
Precedence: bulk


On Tue, Jun 8, 2021, at 11:15 AM, Dave Hansen wrote:
> On 6/8/21 11:12 AM, Andi Kleen wrote:
> > I believe neither does mmio/msr normally (except maybe
> > ftrace+tp_printk, but that will likely work because it shouldn't
> > recurse more than once due to ftrace's reentry protection)
> 
> Can it do MMIO:
> 
> > +DEFINE_IDTENTRY(exc_virtualization_exception)
> > +{
> =======> HERE
> > +    ret = tdg_get_ve_info(&ve); 
> 
> Recursion isn't the problem.  It would double-fault there, right?
> 

We should do the get_ve_info in a noinstr region.