Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4359712pxj; Tue, 8 Jun 2021 12:21:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTBET/Wx/dqJ6zjGRvA3tnECJpgwJYxivaycmBMTOtl/1v+warrUTWDqEl4JHEQYxXkqeo X-Received: by 2002:aa7:d7cf:: with SMTP id e15mr27862775eds.114.1623180117011; Tue, 08 Jun 2021 12:21:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623180117; cv=none; d=google.com; s=arc-20160816; b=ZjefUMnHIrmlUWrVVrpUM/vKtNpUYLv5b5zvkLnK2nvgLeiYxd6rHNXBHhVh7UCNSR YXWpDdWIH/m0gnNiLCtsO+7KoLSn+SccioHpZlyocI08dCRy10/Fww4I1EDpp18uxtBx B2hRbm1IrMI7yrjrJY4sZqocaGQbMvysTjpjdoKelCPYKM9japtsRmQI40po/VRYrL9K COwcUL+0R4MYoZYXE60ZYDlDLuYbeA7RbF775WG8cwLFVD/M7ZYoI2VbX4YK3S3AXV7/ U8HucUf+6IvtDxF4vtpHbi09aUXXi4sSJj2NC+9HEARLbY3Wgz30dSIyWUazKxQAi63v QzMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=za4IWyr9qK271xF1EKwF3GWCUaKD36nVfm7iQJhbaQE=; b=vZGgofSF2S32sXEV7SO0wTd9tm42J3XQj81WEHXtL8Imze1A4eak8AlgX44sS2H0Sa m4tPOnWKUcl44obBoY/tolUdvVMpHZHNS2G7B1gL1fVcgDXMWG2Vll20fwP8sJALuaPD jxQtNd3E4uCmjbTZbZQVbdkLTY1sEILeWTCugVMhtvMDzKbrdgLMeM7bzkuZThAWx3UX saOkxgrriPZbZWNHsXotdkx2n6RfCT9h1tjCzTcYvkAo7GWpXkjLaYEqsDwp7Sm0ZgKd 5XDowt+wGFBisjIZLjtEuwrKhHCpbWkMitI8yq5c0CY/7O4+OAz7jWT4ODXnKb3G4MxC 49ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="XpJ0s6/U"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si468624edr.39.2021.06.08.12.21.34; Tue, 08 Jun 2021 12:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="XpJ0s6/U"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236884AbhFHTS5 (ORCPT + 99 others); Tue, 8 Jun 2021 15:18:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236883AbhFHTHe (ORCPT ); Tue, 8 Jun 2021 15:07:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 870AB613DD; Tue, 8 Jun 2021 18:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623178046; bh=HknkZSdCF5cb0LuMUeofYonfHPm0HaaahJeapgMFrys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XpJ0s6/UV2BgGcIlSlIQ/9GLbxKjPSnBqkCVMGHqfTmmL2A+6VvlUaOp8FEV8jPBV oWVa0EnBsJ5WIPoWtG5Lm5+taRmviBi2GCRSRsb7hyUP/D10mYXlaLl/G0cR5XaEmv LdGOnBhdBdbXRIcFjjVikniHFkJqxfqDr5wZ9+FE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roja Rani Yarubandi , Stephen Boyd , Wolfram Sang , Sasha Levin Subject: [PATCH 5.12 057/161] i2c: qcom-geni: Add shutdown callback for i2c Date: Tue, 8 Jun 2021 20:26:27 +0200 Message-Id: <20210608175947.394182460@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175945.476074951@linuxfoundation.org> References: <20210608175945.476074951@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roja Rani Yarubandi [ Upstream commit 9f78c607600ce4f2a952560de26534715236f612 ] If the hardware is still accessing memory after SMMU translation is disabled (as part of smmu shutdown callback), then the IOVAs (I/O virtual address) which it was using will go on the bus as the physical addresses which will result in unknown crashes like NoC/interconnect errors. So, implement shutdown callback for i2c driver to suspend the bus during system "reboot" or "shutdown". Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") Signed-off-by: Roja Rani Yarubandi Reviewed-by: Stephen Boyd Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-qcom-geni.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 214b4c913a13..c3ae66ba6345 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -650,6 +650,14 @@ static int geni_i2c_remove(struct platform_device *pdev) return 0; } +static void geni_i2c_shutdown(struct platform_device *pdev) +{ + struct geni_i2c_dev *gi2c = platform_get_drvdata(pdev); + + /* Make client i2c transfers start failing */ + i2c_mark_adapter_suspended(&gi2c->adap); +} + static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) { int ret; @@ -714,6 +722,7 @@ MODULE_DEVICE_TABLE(of, geni_i2c_dt_match); static struct platform_driver geni_i2c_driver = { .probe = geni_i2c_probe, .remove = geni_i2c_remove, + .shutdown = geni_i2c_shutdown, .driver = { .name = "geni_i2c", .pm = &geni_i2c_pm_ops, -- 2.30.2