Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     Baokun Li <libaokun1@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vinod Koul <vkoul@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        Shravya Kumbham <shravyak@xilinx.com>,
        Matthew Murrian <matthew.murrian@goctsi.com>,
        Romain Perier <romain.perier@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Allen Pais <allen.lkml@gmail.com>
CC:     "weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
        "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
        "yangjihong1@huawei.com" <yangjihong1@huawei.com>,
        "yukuai3@huawei.com" <yukuai3@huawei.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead
 of list_del/list_add_tail
Thread-Topic: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead
 of list_del/list_add_tail
Thread-Index: AQHXXBJ69U+tzbPdL0iCGBaFy2bVS6sKGIxw
Date:   Tue, 8 Jun 2021 13:16:56 +0000
Message-ID: <CH2PR02MB6523048911423F5583772FE9C7379@CH2PR02MB6523.namprd02.prod.outlook.com>
References: <20210608030905.2818831-1-libaokun1@huawei.com>
In-Reply-To: <20210608030905.2818831-1-libaokun1@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MWEpsn0tvgbK+sf9HQCe0kdR2+ZdxT5EORMGedvwrigfLqYP9d/ESJs/ChIe?=
 =?us-ascii?Q?0Xap3LFbqSSLN2c/mTl2iGmM8M/8OcNKLaT73l6CV92JqAK6yRHvzqFyu3a5?=
 =?us-ascii?Q?NEbyHL5c3fP42iYEVxHFkchGJ8HpFKkIXAm3nZvG+GyDatMrjy5G7CfnHNOT?=
 =?us-ascii?Q?t+7fC1TZLjt9Jroo+vglVdx6izAG1gwjIALe4j35TO6mIIoP8uzHQG3GZ6uR?=
 =?us-ascii?Q?Lhu+Wl2nAbC9LQN4wgftNSwV/lIjkrZC+lvvez+ztE2W+IQZbU/GKGqKTr3q?=
 =?us-ascii?Q?upxbg2eGYvQdBC4k5PHx+gvMMz/tLlEuKZNEDYud/gzN27NAAQ2NCW3sf9KR?=
 =?us-ascii?Q?zpbRcUHepwSz/OFQJhvY7f9V7BaGP5tU8gBQ2uum7XHIIMTdepRWSSQo+Ob0?=
 =?us-ascii?Q?ixpcjk8I//kk1dYX2X3lpwhmyrKtlfMWPEHK3uVqGo2IPsvF360bv0lFWM3r?=
 =?us-ascii?Q?ISwN0Caf2sN3ZPQWNGduxwiBfHmg8ARAFORalD2fJNgyFKnK7C8IktRBteLL?=
 =?us-ascii?Q?BQ0sbUR4zw0SczxYzX4R8tTpCCGwx+zb4w5NKAv3+icx+3/fPF1bfeLc0R5b?=
 =?us-ascii?Q?iY+z7svqwQFDN8qE0VTIAI3fxQHF/fSRN8f6y1/oepEn04kCXGjElrVlzDjB?=
 =?us-ascii?Q?gBX4JSprJPagzNUuxdy7MPTYloeTp7gL8dtYR21JrkHGihgSN57Frx4oEISm?=
 =?us-ascii?Q?D419HONCCHGUIyVeyVTpcEaq+H0fj3OfKbzUrGhnjGW58i4yBv7vGU3SAG7G?=
 =?us-ascii?Q?NOmhCgTOY6t0/zx2m60GU38nquIlYXnr783B1DaveRgNviXqszDdD2Qp7erU?=
 =?us-ascii?Q?Yd6jzH8Zm21Ze1uCAa8hAcr0tMKZmMYmCb9WVNV3FFd/O+NIC/4Nb9o3jEdm?=
 =?us-ascii?Q?s+kgBGah9ZFwobu9iT6L5mKFmiBbPybjkrucMp38lFd3vbAAGynRYia8a7uy?=
 =?us-ascii?Q?2/fuiAReQ8C9iL1jz0i27Mnz7YCaSzEFVkSN39QgJwBcjhIb+HAO01Yx15h7?=
 =?us-ascii?Q?VLQxkQTMn6ZOIL1FhiawH4AGpOXiLoE34W5tbfcObs5FvH9Qd/3tZ7IO4z5c?=
 =?us-ascii?Q?gb/1cMc3U8L4XTzX1cYQO+Dbk2CRFCZuNcCixEyFoE5fzlskCq5dKc4d4DUf?=
 =?us-ascii?Q?Da99WOyxa+vJ/tLPsjgC+nhEcdxG83iL1GiBGyWelqb4SqLlP6YXUTGpgcos?=
 =?us-ascii?Q?P2bwYAIcc6FlW1AoHXz7HrQCTe8gYUAOkNgU8cnFZ9mqHfh3rrj9J2IK5Y3U?=
 =?us-ascii?Q?CC34I2OzXEk26EDVP+TvqZqB0Hr6YMN2YQyJ5wfUanRn9lQU304TX1P5YDxM?=
 =?us-ascii?Q?BJ/7pS0USMqIO6AFBthxDoEF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR02MB6523.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b587c96e-76e8-40f1-ff67-08d92a7fb0a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2021 13:16:56.0534
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /zOiU82oRgB3o4EmR3wA5EHgNZnKD+zy0dqDlu4wYHu2e1kMbqPwIinZeO3dBTIXswOlopEvN9Ocp9O/rV6dlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8026
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Baokun Li <libaokun1@huawei.com>
> Sent: Tuesday, June 8, 2021 8:39 AM
> To: linux-kernel@vger.kernel.org; Vinod Koul <vkoul@kernel.org>; Michal
> Simek <michals@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com>;
> Shravya Kumbham <shravyak@xilinx.com>; Matthew Murrian
> <matthew.murrian@goctsi.com>; Romain Perier
> <romain.perier@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> Krzysztof Kozlowski <krzk@kernel.org>; Allen Pais <allen.lkml@gmail.com>
> Cc: weiyongjun1@huawei.com; yuehaibing@huawei.com;
> yangjihong1@huawei.com; yukuai3@huawei.com; libaokun1@huawei.com;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; kernel-
> janitors@vger.kernel.org; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead =
of
> list_del/list_add_tail
>=20
> Using list_move_tail() instead of list_del() + list_add_tail().
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_=
dma.c
> index 75c0b8e904e5..77022ef05ac5 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
>=20
>  	chan->desc_submitcount++;
>  	chan->desc_pendingcount--;
> -	list_del(&desc->node);
> -	list_add_tail(&desc->node, &chan->active_list);
> +	list_move_tail(&desc->node, &chan->active_list);
>  	if (chan->desc_submitcount =3D=3D chan->num_frms)
>  		chan->desc_submitcount =3D 0;
>=20