Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   jarmo.tiitto@gmail.com
To:     Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>,
        clang-built-linux@googlegroups.com, Bill Wendling <wcw@google.com>,
        Sami Tolvanen <samitolvanen@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-kernel@vger.kernel.org
Cc:     morbo@google.com, Jarmo Tiitto <jarmo.tiitto@gmail.com>
Subject: Re: [PATCH v3 1/1] pgo: Fix sleep in atomic section in prf_open() v3
Date:   Tue, 08 Jun 2021 16:50:45 +0300
Message-ID: <1989067.FY1I2HCei6@hyperiorarchmachine>
In-Reply-To: <162310696843.3797458.16031727600580374864.b4-ty@chromium.org>
References: <20210605183128.129614-1-jarmo.tiitto@gmail.com> <162310696843.3797458.16031727600580374864.b4-ty@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

Kees Cook wrote tiistaina 8. kes=C3=A4kuuta 2021 2.02.51 EEST:
> On Sat, 5 Jun 2021 21:31:29 +0300, Jarmo Tiitto wrote:
> > In prf_open() the required buffer size can be so large that
> > vzalloc() may sleep thus triggering bug:
> >=20
> > =3D=3D=3D=3D=3D=3D
> >=20
> >  BUG: sleeping function called from invalid context at
> >  include/linux/sched/mm.h:201 in_atomic(): 1, irqs_disabled(): 1,
> >  non_block: 0, pid: 337, name: cat CPU: 1 PID: 337 Comm: cat Not tainted
> >  5.13.0-rc2-24-hack+ #154
> >  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2=
015
> > =20
> >  Call Trace:
> >   dump_stack+0xc7/0x134
> >   ___might_sleep+0x177/0x190
> >   __might_sleep+0x5a/0x90
> >   kmem_cache_alloc_node_trace+0x6b/0x3a0
> >   ? __get_vm_area_node+0xcd/0x1b0
> >   ? dput+0x283/0x300
> >   __get_vm_area_node+0xcd/0x1b0
> >   __vmalloc_node_range+0x7b/0x420
> >   ? prf_open+0x1da/0x580
> >   ? prf_open+0x32/0x580
> >   ? __llvm_profile_instrument_memop+0x36/0x50
> >   vzalloc+0x54/0x60
> >   ? prf_open+0x1da/0x580
> >   prf_open+0x1da/0x580
> >   full_proxy_open+0x211/0x370
> >   ....
> >=20
> > =3D=3D=3D=3D=3D=3D
> >=20
> > [...]
>=20
> Applied to for-next/clang/features, thanks! I made some additional tweaks
> on top of this, in a separate patch I just sent out.
>=20
> [1/1] pgo: Fix sleep in atomic section in prf_open() v3
>       https://git.kernel.org/kees/c/d13b0485a7bb
>=20
> --
> Kees Cook

Oof. Looking now at your fixes, I'm sorry for the extra work needed. :-|
I should have cleaned up the error paths better, since that was mentioned=20
earlier.
My eyes were apparently pointed on the v2 module profiling code I have been=
=20
brewing the past weekend.=20

Thanks!
=2D-
Jarmo