Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Jun 2021 11:17:44 -0400
From:   Richard Guy Briggs <rgb@redhat.com>
To:     Zhen Lei <thunder.leizhen@huawei.com>
Cc:     Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
        linux-audit <linux-audit@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] audit: remove trailing spaces and tabs
Message-ID: <20210608151744.GD2268484@madcap2.tricolour.ca>
References: <20210608075437.13120-1-thunder.leizhen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210608075437.13120-1-thunder.leizhen@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2021-06-08 15:54, Zhen Lei wrote:
> Run the following command to find and remove the trailing spaces and tabs:
> 
> sed -r -i 's/[ \t]+$//' kernel/audit*

The api header include/uapi/linux/audit.h should probably be included.

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  kernel/audit.h   | 2 +-
>  kernel/auditsc.c | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/audit.h b/kernel/audit.h
> index 1522e100fd17..cab3e2652dab 100644
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0-or-later */
> -/* audit -- definition of audit_context structure and supporting types 
> +/* audit -- definition of audit_context structure and supporting types
>   *
>   * Copyright 2003-2004 Red Hat, Inc.
>   * Copyright 2005 Hewlett-Packard Development Company, L.P.
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 0a9a1569f1ea..679a43fd342a 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -343,13 +343,13 @@ static int audit_compare_uid(kuid_t uid,
>  {
>  	struct audit_names *n;
>  	int rc;
> - 
> +
>  	if (name) {
>  		rc = audit_uid_comparator(uid, f->op, name->uid);
>  		if (rc)
>  			return rc;
>  	}
> - 
> +
>  	if (ctx) {
>  		list_for_each_entry(n, &ctx->names_list, list) {
>  			rc = audit_uid_comparator(uid, f->op, n->uid);
> @@ -367,13 +367,13 @@ static int audit_compare_gid(kgid_t gid,
>  {
>  	struct audit_names *n;
>  	int rc;
> - 
> +
>  	if (name) {
>  		rc = audit_gid_comparator(gid, f->op, name->gid);
>  		if (rc)
>  			return rc;
>  	}
> - 
> +
>  	if (ctx) {
>  		list_for_each_entry(n, &ctx->names_list, list) {
>  			rc = audit_gid_comparator(gid, f->op, n->gid);
> -- 
> 2.25.1

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635