Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4621903pxj; Tue, 8 Jun 2021 20:08:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGSLaSAshzKPTYDCvRIWc7uUb0GncTz7aZ8jqlyB/CKGVzdoZaS9+eJ5OPoaSY3Rpij9m9 X-Received: by 2002:a05:6402:1216:: with SMTP id c22mr28491292edw.36.1623208100823; Tue, 08 Jun 2021 20:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623208100; cv=none; d=google.com; s=arc-20160816; b=Mkym+Wj8ckhjkP+hXj0izW986rHfZ6zvB+RD5eijPVkaaQsN5YElto2StrXTWNEsJe OubOuPHytkx4OQPEnUyTl3OogZEYvlahaggzFoo+2K36u486IYEiGfY3oS3Vszy0TVcm fx1p4IM5lugm7n6o+ac70A6+cfbn2KQSc8wKNQddpRW7maZY7QqAarpuURws3QlXDRpK WPUs1yyy33OoB6TYzgSpxs3f/RkDizMVg8/e7jNkvrjzEHvbIzPK9asYDkNIVu+1VjR8 jokfXe9eMyu0UZKf1wTlctt80VrfGriR7rHMptShlf456fpdmcjBMFXtW7X26s6bE7v3 gYQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=ZBJEHdSWntFaR1di2cSYSVQKl/fJ/upIcuZ2McqMt3g=; b=fiUBls+q57FxJMlM8ztkhWGvZsstzX4HbfUwHUd2E8D4t8208cTFVjA0JnEFX6Fyo2 Jx9QZ7gqDDFu+DkS/kdhBVpvmFapC8gU5k6pxSpAooZxtpmmMV7Qk7B1MC7VkQDIhgsn 7v1XbUK/3l/HgA6ci+k1XNR9sEeLNa8Gg5J2J5D0HMSmbDk2Iv5RWGqTJJDBr2pqU1+x znW2SzrJm2O8ODOR6yuVZVelblC2dQHA9qiaYYlPt7x+ei55DEq/V7TArbU50gnYZ7dD SpHyDjbGPtxzgc0wpMJT80TyQF40twdvUu5sAURrbk5gX52LbJ+2BLamlrB683m9uWYS 2yVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b="Vs/gpuN0"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b="R9A8/zV2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i19si1305258edb.180.2021.06.08.20.07.57; Tue, 08 Jun 2021 20:08:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b="Vs/gpuN0"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b="R9A8/zV2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233410AbhFHOha (ORCPT + 99 others); Tue, 8 Jun 2021 10:37:30 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:50319 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbhFHOh1 (ORCPT ); Tue, 8 Jun 2021 10:37:27 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AC4C81B4E; Tue, 8 Jun 2021 10:35:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 08 Jun 2021 10:35:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=Z BJEHdSWntFaR1di2cSYSVQKl/fJ/upIcuZ2McqMt3g=; b=Vs/gpuN0XDSjEVmTZ s+k72E87oIbJdsjp5jXxFvTwf/5nl5azsb8mNBFhMrrAWoZjKiVa+FR0AqU66ENY gQSOgkKCuUs5EKhHf8aqCp6cZx4tmz2x6/S352Xsf7ViQ0eQ+027IRA37tVx3U0x dXa7SmczRo0jaUA2nb5nD9Da6fRantnSYPAmoovy5eYu+0keS29ASuVdNzH2C3Ne g34IkgS8JGol3AS0xZdjQD8avM0ifiCt6bsygULVf6UhPLHm7+UUrHd92oeiYQOy b2es+H+UrQ5HDHN0dBBgE2E36PaHSbq6uXptn5rVBQv0usc6s4lXzfIXR/ChGAtG 5CXyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZBJEHdSWntFaR1di2cSYSVQKl/fJ/upIcuZ2McqMt 3g=; b=R9A8/zV2lR1tYxZVdW09dhtrB2QCcG0OeZz/0WO4MzgfZS5rYW4wvtVFk ngOQ/KYVGSWfbNlsIdkPlqax6PIN6tXI5Wywxack9CpYOiEWSr9qvxjCGqSBFsmx Q+D/qx0zXD/nHSYHeb+Wim8M7pqrVyjr+EPHMYUUL8p5ecOZvk4DdxD30p85Z6WK CINy8KSL5SyrDW4v1jbJP1w2GJZK6f7Vx4TaVUY+PMIV1lH3v8rJ3l4ukO41OTi6 WGekZpjg9z55WPZwFZls/wb0iN07g1QIQ7DPVepJOGyBWr0dD4x8JaygvbG5UUWW /0thip0HFtAFYEHO8onBOJ7ZmniuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtledgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepgeeije euvdffuedvffdtteefuefhkeehgfeuffejveettdelgfeuudffffetfedtnecuffhomhgr ihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Jun 2021 10:35:31 -0400 (EDT) Date: Tue, 8 Jun 2021 16:35:30 +0200 From: Greg KH To: Salvatore Bonaccorso Cc: =?utf-8?Q?Lauren=C8=9Biu_P=C4=83ncescu?= , stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Backporting fix for #199981 to 4.19.y? Message-ID: References: <5399984e-0860-170e-377e-1f4bf3ccb3a0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 06, 2021 at 02:34:11PM +0200, Salvatore Bonaccorso wrote: > Hi Laurențiu, Greg, > > On Fri, Jun 04, 2021 at 05:42:02PM +0200, Greg KH wrote: > > On Fri, Jun 04, 2021 at 04:50:19PM +0200, Laurențiu Păncescu wrote: > > > Hi Greg, > > > > > > On 6/3/21 11:19 AM, Greg KH wrote: > > > > That commit does not apply cleanly and I need a backported version. Can > > > > you do that and test it to verify it works and then send it to us to be > > > > applied? > > > > > > I now have a patch against linux-4.19.y, tested on my EeePC just now: the > > > battery status and discharge rate are shown correctly. > > > > > > I've never submitted a patch before, should I put "commit > > > upstream." as the first line of my commit message, followed by another line > > > stating which branch I would like this to be merged to? Should I also > > > include the original commit message of the backported commit? And then use > > > git format-patch? I just read through [1] and [2], but they don't say > > > anything specific about commit messages for backported patches. > > > > Yes, what you describe here should be great. Look at the stable mailing > > list archives on lore.kernel.org for other examples of this happening, > > https://lore.kernel.org/r/20210603162852.1814513-1-zsm@chromium.org is > > one example. > > Instead of doing a specific backport, maybe it is enough to pick > a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless > of module-level code flag") frst on 4.19.y and then the mentioned fix > b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling > acpi_load_tables()"). I do not see a commit a46393c02c76 in Linus's tree :( Are you sure these ids are correct? thanks, greg k-h