Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b77a3e7b0923344e8c5b9b17f4788d28f3ccfb4f.camel@perches.com>
Subject: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to
 assign broadcast address
From:   Joe Perches <joe@perches.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Liu Shixin <liushixin2@huawei.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Date:   Tue, 08 Jun 2021 09:45:49 -0700
In-Reply-To: <YL96vz4okNehxCBG@kroah.com>
References: <20210608141620.525521-1-liushixin2@huawei.com>
         <YL96vz4okNehxCBG@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-06-08 at 16:12 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 08, 2021 at 10:16:20PM +0800, Liu Shixin wrote:
> > Use eth_broadcast_addr() to assign broadcast address.
> 
> That says what you do, but not _why_ you are doing this?
> 
> Why make this change?  What benifit does it provide?

The commit message is clear and concise as using available kernel
mechanisms is better than homegrown or duplicative ones.

Are you asking merely becuse Liu Shixin hasn't had many staging
commits?