Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Jun 2021 17:48:44 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Raj Ashok <ashok.raj@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 08/32] x86/traps: Add #VE support for TDX guest
Message-ID: <YL+tfGOMWEvDJTwc@google.com>
References: <cover.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <8a1d6930f784cb57c957cf20cea870947db91e05.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <fe05830e-e82b-f338-2ba1-02651cb8087e@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe05830e-e82b-f338-2ba1-02651cb8087e@intel.com>
Precedence: bulk

On Tue, Jun 08, 2021, Dave Hansen wrote:
> On 4/26/21 11:01 AM, Kuppuswamy Sathyanarayanan wrote:
> > +#ifdef CONFIG_INTEL_TDX_GUEST
> > +DEFINE_IDTENTRY(exc_virtualization_exception)
> > +{
> > +	struct ve_info ve;
> > +	int ret;
> > +
> > +	RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU");
> > +
> > +	/*
> > +	 * Consume #VE info before re-enabling interrupts. It will be
> > +	 * re-enabled after executing the TDGETVEINFO TDCALL.
> > +	 */
> > +	ret = tdg_get_ve_info(&ve);
> 
> Is it safe to have *anything* before the tdg_get_ve_info()?  For
> instance, say that RCU_LOCKDEP_WARN() triggers.  Will anything in there
> do MMIO?

I doubt it's safe, anything that's doing printing has the potential to trigger
#VE.  Even if we can prove it's safe for all possible paths, I can't think of a
reason to allow anything that's not absolutely necessary before retrieving the
#VE info.